diff options
| author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2012-11-26 15:05:14 +0200 |
|---|---|---|
| committer | hjk <qthjk@ovi.com> | 2012-11-27 08:58:48 +0100 |
| commit | f4a06ffd06970a19bb9ecc7eff0d915d9ead8c2b (patch) | |
| tree | 855e97d8ada48259c22fee1e74c6d57b26f8e134 /src/plugins/valgrind/callgrind/callgrinddatamodel.cpp | |
| parent | 6d4846a78c598f0baebfd5f6d5da2c1248bfa234 (diff) | |
| download | qt-creator-f4a06ffd06970a19bb9ecc7eff0d915d9ead8c2b.tar.gz | |
Valgrind: Clean up html construction
Change-Id: I38a6004883f0ae109b43757e8bad3a42c8b5b9cb
Reviewed-by: hjk <qthjk@ovi.com>
Diffstat (limited to 'src/plugins/valgrind/callgrind/callgrinddatamodel.cpp')
| -rw-r--r-- | src/plugins/valgrind/callgrind/callgrinddatamodel.cpp | 52 |
1 files changed, 27 insertions, 25 deletions
diff --git a/src/plugins/valgrind/callgrind/callgrinddatamodel.cpp b/src/plugins/valgrind/callgrind/callgrinddatamodel.cpp index 4df2c0afd0..20df7fda22 100644 --- a/src/plugins/valgrind/callgrind/callgrinddatamodel.cpp +++ b/src/plugins/valgrind/callgrind/callgrinddatamodel.cpp @@ -258,37 +258,39 @@ QVariant DataModel::data(const QModelIndex &index, int role) const if (!d->m_verboseToolTips) return data(index, Qt::DisplayRole); - QString ret = "<html><head><style>\ + QString ret = QLatin1String("<html><head><style>\ dt { font-weight: bold; }\ dd { font-family: monospace; }\ tr.head, td.head { font-weight: bold; }\ tr.head { text-decoration: underline; }\ td.group { padding-left: 20px; }\ td { white-space: nowrap; }\ - </style></head>\n"; + </style></head>\n<body><dl>"); + QString entry = QLatin1String("<dt>%1</dt><dd>%2</dd>\n"); // body, function info first - ret += "<body><dl>"; - ret += "<dt>" + tr("Function:") + "</dt><dd>" + Qt::escape(func->name()) + "</dd>\n"; - ret += "<dt>" + tr("File:") + "</dt><dd>" + func->file() + "</dd>\n"; + ret += entry.arg(tr("Function:")).arg(Qt::escape(func->name())); + ret += entry.arg(tr("File:")).arg(func->file()); if (!func->costItems().isEmpty()) { const CostItem *firstItem = func->costItems().first(); for (int i = 0; i < d->m_data->positions().size(); ++i) { - ret += "<dt>" + ParseData::prettyStringForPosition(d->m_data->positions().at(i)) + "</dt>"; - ret += "<dd>" + QString::number(firstItem->position(i)) + "</dd>\n"; + ret += entry.arg(ParseData::prettyStringForPosition(d->m_data->positions().at(i))) + .arg(firstItem->position(i)); } } - ret += "<dt>" + tr("Object:") + "</dt><dd>" + func->object() + "</dd>\n"; - ret += "<dt>" + tr("Called:") + "</dt><dd>" + tr("%n time(s)", 0, func->called()) + "</dd>\n"; - ret += "</dl><p/>"; + ret += entry.arg(tr("Object:")).arg(func->object()); + ret += entry.arg(tr("Called:")).arg(tr("%n time(s)", 0, func->called())); + ret += QLatin1String("</dl><p/>"); // self/inclusive costs - ret += "<table>"; - ret += "<thead><tr class='head'><td>" + tr("Events") + "</td>"; - ret += "<td class='group'>" + tr("Self costs") + "</td><td>" + tr("(%)") + "</td>"; - ret += "<td class='group'>" + tr("Incl. costs") + "</td><td>" + tr("(%)") + "</td>"; - ret += "</tr></thead>"; - ret += "<tbody>"; + entry = QLatin1String("<td class='group'>%1</td><td>%2</td>"); + ret += QLatin1String("<table>"); + ret += QLatin1String("<thead><tr class='head'>"); + ret += QLatin1String("<td>") + tr("Events") + QLatin1String("</td>"); + ret += entry.arg(tr("Self costs")).arg(tr("(%)")); + ret += entry.arg(tr("Incl. costs")).arg(tr("(%)")); + ret += QLatin1String("</tr></thead>"); + ret += QLatin1String("<tbody>"); for (int i = 0; i < d->m_data->events().size(); ++i) { quint64 selfCost = func->selfCost(i); quint64 inclCost = func->inclusiveCost(i); @@ -297,16 +299,16 @@ QVariant DataModel::data(const QModelIndex &index, int role) const const float relSelfCost = (float)qRound((float)selfCost / totalCost * 10000) / 100; const float relInclCost = (float)qRound((float)inclCost / totalCost * 10000) / 100; - ret += "<tr>"; - ret += "<td class='head'><nobr>" + noWrap(ParseData::prettyStringForEvent(d->m_data->events().at(i))) + "</nobr></td>"; - ret += "<td class='group'>" + tr("%1").arg(selfCost) + "</td>"; - ret += "<td>" + tr("(%1%)").arg(relSelfCost) + "</td>"; - ret += "<td class='group'>" + tr("%1").arg(inclCost) + "</td>"; - ret += "<td>" + tr("(%1%)").arg(relInclCost) + "</td>"; - ret += "</tr>"; + ret += QLatin1String("<tr>"); + ret += QLatin1String("<td class='head'><nobr>") + + noWrap(ParseData::prettyStringForEvent(d->m_data->events().at(i))) + + QLatin1String("</nobr></td>"); + ret += entry.arg(selfCost).arg(tr("(%1%)").arg(relSelfCost)); + ret += entry.arg(inclCost).arg(tr("(%1%)").arg(relInclCost)); + ret += QLatin1String("</tr>"); } - ret += "</tbody></table>"; - ret += "</body></html>"; + ret += QLatin1String("</tbody></table>"); + ret += QLatin1String("</body></html>"); return ret; } |