diff options
author | hjk <hjk@qt.io> | 2018-02-02 10:08:21 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2018-02-06 11:58:15 +0000 |
commit | 713b8636ea740502597b79b1a74382d1b3a70ab6 (patch) | |
tree | a1ece14ba7f98d1fa2ce01e4880c707dc5a74082 /src/plugins/subversion | |
parent | e7792f8f50b21889f727884ab8b94cb87f38169e (diff) | |
download | qt-creator-713b8636ea740502597b79b1a74382d1b3a70ab6.tar.gz |
Vcs/Text search: Remove a few addAutoReleaseObject uses
Using a QObject parent suffices here.
Change-Id: I4dc5448511d55bf14fbd8f810e91336a49e94094
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/subversion')
-rw-r--r-- | src/plugins/subversion/settingspage.cpp | 4 | ||||
-rw-r--r-- | src/plugins/subversion/settingspage.h | 2 | ||||
-rw-r--r-- | src/plugins/subversion/subversionplugin.cpp | 11 |
3 files changed, 8 insertions, 9 deletions
diff --git a/src/plugins/subversion/settingspage.cpp b/src/plugins/subversion/settingspage.cpp index c6a0dbed57..2ffee34344 100644 --- a/src/plugins/subversion/settingspage.cpp +++ b/src/plugins/subversion/settingspage.cpp @@ -80,8 +80,8 @@ void SettingsPageWidget::setSettings(const VcsBaseClientSettings &s) m_ui.logCountSpinBox->setValue(s.intValue(SubversionSettings::logCountKey)); } -SettingsPage::SettingsPage(Core::IVersionControl *control) : - VcsClientOptionsPage(control, SubversionPlugin::instance()->client()) +SettingsPage::SettingsPage(Core::IVersionControl *control, QObject *parent) : + VcsClientOptionsPage(control, SubversionPlugin::instance()->client(), parent) { setId(VcsBase::Constants::VCS_ID_SUBVERSION); setDisplayName(tr("Subversion")); diff --git a/src/plugins/subversion/settingspage.h b/src/plugins/subversion/settingspage.h index d532394027..e23e4176ff 100644 --- a/src/plugins/subversion/settingspage.h +++ b/src/plugins/subversion/settingspage.h @@ -56,7 +56,7 @@ class SettingsPage : public VcsBase::VcsClientOptionsPage Q_OBJECT public: - SettingsPage(Core::IVersionControl *control); + SettingsPage(Core::IVersionControl *control, QObject *parent); }; } // namespace Subversion diff --git a/src/plugins/subversion/subversionplugin.cpp b/src/plugins/subversion/subversionplugin.cpp index 7748a08c4d..8084e37603 100644 --- a/src/plugins/subversion/subversionplugin.cpp +++ b/src/plugins/subversion/subversionplugin.cpp @@ -216,10 +216,10 @@ bool SubversionPlugin::initialize(const QStringList & /*arguments */, QString *e m_client = new SubversionClient; - addAutoReleasedObject(new SettingsPage(versionControl())); + new SettingsPage(versionControl(), this); - addAutoReleasedObject(new VcsSubmitEditorFactory(&submitParameters, - []() { return new SubversionSubmitEditor(&submitParameters); })); + new VcsSubmitEditorFactory(&submitParameters, + []() { return new SubversionSubmitEditor(&submitParameters); }, this); const auto describeFunc = [this](const QString &source, const QString &id) { describe(source, id); @@ -227,11 +227,10 @@ bool SubversionPlugin::initialize(const QStringList & /*arguments */, QString *e const int editorCount = sizeof(editorParameters) / sizeof(editorParameters[0]); const auto widgetCreator = []() { return new SubversionEditorWidget; }; for (int i = 0; i < editorCount; i++) - addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc)); + new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this); const QString prefix = QLatin1String("svn"); - m_commandLocator = new CommandLocator("Subversion", prefix, prefix); - addAutoReleasedObject(m_commandLocator); + m_commandLocator = new CommandLocator("Subversion", prefix, prefix, this); // Register actions ActionContainer *toolsContainer = ActionManager::actionContainer(M_TOOLS); |