diff options
author | Daniel Teske <daniel.teske@digia.com> | 2014-07-07 19:02:26 +0200 |
---|---|---|
committer | Daniel Teske <daniel.teske@digia.com> | 2014-07-16 18:20:57 +0200 |
commit | eccf1dc1e397303e218eaaf48977fd612cbd3d6a (patch) | |
tree | 0681cde5b07e72b5667820c7e4a14d2ff88f4ed1 /src/plugins/qtsupport/qtkitconfigwidget.cpp | |
parent | 71b56d2b9c3264bd481915c763aac685c1ad24d0 (diff) | |
download | qt-creator-eccf1dc1e397303e218eaaf48977fd612cbd3d6a.tar.gz |
Even more algorithm usage in ProjectExplorer
Add Utils::transform and anyOf that take a member function pointer.
Remove bestElementOr it's unused.
Use declval<T> in transform's return type, because msvc does evaluate
T() and for types that don't have simple constructor this fails.
Add std::remove_reference since decltype returns a reference for
lvalues.
Change-Id: I22248b226748eeb27af0d300182d574438d7f756
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Diffstat (limited to 'src/plugins/qtsupport/qtkitconfigwidget.cpp')
-rw-r--r-- | src/plugins/qtsupport/qtkitconfigwidget.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/plugins/qtsupport/qtkitconfigwidget.cpp b/src/plugins/qtsupport/qtkitconfigwidget.cpp index 2613e7d439..129ab7f953 100644 --- a/src/plugins/qtsupport/qtkitconfigwidget.cpp +++ b/src/plugins/qtsupport/qtkitconfigwidget.cpp @@ -37,6 +37,7 @@ #include <projectexplorer/projectexplorerconstants.h> #include <utils/qtcassert.h> +#include <utils/algorithm.h> #include <QComboBox> #include <QPushButton> @@ -50,9 +51,7 @@ QtKitConfigWidget::QtKitConfigWidget(ProjectExplorer::Kit *k, const ProjectExplo m_combo = new QComboBox; m_combo->addItem(tr("None"), -1); - QList<int> versionIds; - foreach (BaseQtVersion *v, QtVersionManager::versions()) - versionIds.append(v->uniqueId()); + QList<int> versionIds = Utils::transform(QtVersionManager::versions(), &BaseQtVersion::uniqueId); versionsChanged(versionIds, QList<int>(), QList<int>()); m_manageButton = new QPushButton(KitConfigWidget::msgManage()); |