diff options
author | Tobias Hunger <tobias.hunger@nokia.com> | 2011-09-09 09:54:37 +0000 |
---|---|---|
committer | Tobias Hunger <tobias.hunger@nokia.com> | 2011-09-15 14:19:01 +0200 |
commit | caa8bd454eeffa629d47238087f85d06e0f3b359 (patch) | |
tree | 55634bcd55a6b4886e6adb90b6721a994c26a71d /src/plugins/qt4projectmanager | |
parent | 28535f75718c4f242afdf91a1ba0d0ff8f604ba4 (diff) | |
download | qt-creator-caa8bd454eeffa629d47238087f85d06e0f3b359.tar.gz |
qmake: Warn when using a mkspec that might not work with the tool chain
Warn when using a mkspec that might or might not work with the selected
tool chain.
Task-number: QTCREATORBUG-5854
Change-Id: Ifead5108ccd109f66707ad7aa371daead8cb57e7
Reviewed-on: http://codereview.qt-project.org/4522
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Diffstat (limited to 'src/plugins/qt4projectmanager')
-rw-r--r-- | src/plugins/qt4projectmanager/qmakestep.cpp | 37 | ||||
-rw-r--r-- | src/plugins/qt4projectmanager/qmakestep.h | 6 |
2 files changed, 38 insertions, 5 deletions
diff --git a/src/plugins/qt4projectmanager/qmakestep.cpp b/src/plugins/qt4projectmanager/qmakestep.cpp index abecb0d5cb..f1f8ed0fe8 100644 --- a/src/plugins/qt4projectmanager/qmakestep.cpp +++ b/src/plugins/qt4projectmanager/qmakestep.cpp @@ -537,6 +537,11 @@ QString QMakeStepConfigWidget::summaryText() const return m_summaryText; } +QString QMakeStepConfigWidget::additionalSummaryText() const +{ + return m_additionalSummaryText; +} + QString QMakeStepConfigWidget::displayName() const { return m_step->displayName(); @@ -664,18 +669,24 @@ void QMakeStepConfigWidget::updateSummaryLabel() Qt4BuildConfiguration *qt4bc = m_step->qt4BuildConfiguration(); QtSupport::BaseQtVersion *qtVersion = qt4bc->qtVersion(); if (!qtVersion) { - m_summaryText = tr("<b>qmake:</b> No Qt version set. Cannot run qmake."); - emit updateSummary(); + setSummaryText(tr("<b>qmake:</b> No Qt version set. Cannot run qmake.")); return; } - // We don't want the full path to the .pro file QString args = m_step->allArguments(true); // And we only use the .pro filename not the full path QString program = QFileInfo(qtVersion->qmakeCommand()).fileName(); - m_summaryText = tr("<b>qmake:</b> %1 %2").arg(program, args); - emit updateSummary(); + setSummaryText(tr("<b>qmake:</b> %1 %2").arg(program, args)); + ToolChain *tc = qt4bc->toolChain(); + if (!tc) + return; + + QString tcSpec = tc->mkspec(); + if (!tcSpec.isEmpty() && tcSpec != m_step->mkspec()) + setAdditionalSummaryText(tr("<b>Warning:</b> The tool chain suggested \"%1\" as mkspec.").arg(tcSpec)); + else + setAdditionalSummaryText(QString()); } void QMakeStepConfigWidget::updateQmlDebuggingOption() @@ -723,6 +734,22 @@ void QMakeStepConfigWidget::recompileMessageBoxFinished(int button) } } +void QMakeStepConfigWidget::setSummaryText(const QString &text) +{ + if (text == m_summaryText) + return; + m_summaryText = text; + emit updateSummary(); +} + +void QMakeStepConfigWidget::setAdditionalSummaryText(const QString &text) +{ + if (text == m_additionalSummaryText) + return; + m_additionalSummaryText = text; + emit updateAdditionalSummary(); +} + //// // QMakeStepFactory //// diff --git a/src/plugins/qt4projectmanager/qmakestep.h b/src/plugins/qt4projectmanager/qmakestep.h index 2a23acbb2e..0a779fb3d0 100644 --- a/src/plugins/qt4projectmanager/qmakestep.h +++ b/src/plugins/qt4projectmanager/qmakestep.h @@ -143,6 +143,7 @@ public: QMakeStepConfigWidget(QMakeStep *step); ~QMakeStepConfigWidget(); QString summaryText() const; + QString additionalSummaryText() const; QString displayName() const; private slots: // slots for handling buildconfiguration/step signals @@ -167,9 +168,14 @@ private: void updateSummaryLabel(); void updateQmlDebuggingOption(); void updateEffectiveQMakeCall(); + + void setSummaryText(const QString &); + void setAdditionalSummaryText(const QString &); + Ui::QMakeStep *m_ui; QMakeStep *m_step; QString m_summaryText; + QString m_additionalSummaryText; bool m_ignoreChange; }; |