diff options
author | Christian Kandeler <christian.kandeler@digia.com> | 2013-06-27 17:12:08 +0200 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@digia.com> | 2013-07-02 15:02:48 +0200 |
commit | 5bca241afb51e89688b88e0dfb6580a5cf23372e (patch) | |
tree | 662b933af89d2fe4c76eb1b470239274e7264b88 /src/plugins/qnx/qnxdevicetester.h | |
parent | d6062643c3994059233fc5e3b082932842c20a81 (diff) | |
download | qt-creator-5bca241afb51e89688b88e0dfb6580a5cf23372e.tar.gz |
Device support: Make device testing a "well-known" concept.
This entails the following:
- Rename AbstractLinuxDeviceTester to DeviceTester and
move it up into ProjectExplorer. The class stays
unchanged, as there was nothing Linux-specific about it.
The same goes for the associated dialog.
- Move the createDeviceTester() function from LinuxDevice
to IDevice and introduce IDevice::hasDeviceTester() to
enable generic code to make use of this feature.
- Move device testing out of the list of opaque
device-specific actions; instead, the device settings widget
now uses the device tester directly, if applicable.
Rationale:
- Device testing, just like remote process listing (if not more so),
is a general concept that implementors of device classes will
probably want to implement (and they should be encouraged to do so).
Without the mechanism provided here, they would all need to put
basically the same code into the actionIds(), displayNameForActionId()
and executeAction() functions.
This patch is the natural extension of b90e3bbd8bea27ad915a4d9033e0d5bda26f5667.
Change-Id: I94f2badb4ceeda9f5cd3b066c13626bb4f65505d
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Diffstat (limited to 'src/plugins/qnx/qnxdevicetester.h')
-rw-r--r-- | src/plugins/qnx/qnxdevicetester.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/qnx/qnxdevicetester.h b/src/plugins/qnx/qnxdevicetester.h index ccec636f08..e3bff15a79 100644 --- a/src/plugins/qnx/qnxdevicetester.h +++ b/src/plugins/qnx/qnxdevicetester.h @@ -43,7 +43,7 @@ class SshRemoteProcessRunner; namespace Qnx { namespace Internal { -class QnxDeviceTester : public RemoteLinux::AbstractLinuxDeviceTester +class QnxDeviceTester : public ProjectExplorer::DeviceTester { Q_OBJECT public: @@ -53,7 +53,7 @@ public: void stopTest(); private slots: - void handleGenericTestFinished(RemoteLinux::AbstractLinuxDeviceTester::TestResult result); + void handleGenericTestFinished(ProjectExplorer::DeviceTester::TestResult result); void handleProcessFinished(int exitStatus); void handleConnectionError(); @@ -70,7 +70,7 @@ private: RemoteLinux::GenericLinuxDeviceTester *m_genericTester; ProjectExplorer::IDevice::ConstPtr m_deviceConfiguration; - TestResult m_result; + ProjectExplorer::DeviceTester::TestResult m_result; State m_state; int m_currentCommandIndex; |