diff options
| author | Thomas Hartmann <Thomas.Hartmann@nokia.com> | 2012-02-14 15:21:21 +0100 |
|---|---|---|
| committer | Thomas Hartmann <Thomas.Hartmann@nokia.com> | 2012-02-15 10:56:54 +0100 |
| commit | 0f073e4a35963d05727871a31898eaf6daf59dc8 (patch) | |
| tree | 173179bf4cea1155759e007085092eb32f3e8251 /src/plugins/qmlprojectmanager | |
| parent | c4b631f97575cca5921a0c8645428354dbcf6745 (diff) | |
| download | qt-creator-0f073e4a35963d05727871a31898eaf6daf59dc8.tar.gz | |
Wizards: avoiding code duplication
I moved setPath(wizardDialogParameters.defaultPath()) into
the constructor of BaseProjectWizardDialog.
I created addExtensionPages() instead of having of having the
foreach everywhere. Moving the call into the constructor of
BaseProjectWizardDialog is not trivial since a lot of derived classes
rely on execution order and the order is often different.
Entangling this is not trivial and easily might break functionality.
Change-Id: I48dddaf72caea84da783dc9e2f42f2c7eff1c0ce
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Diffstat (limited to 'src/plugins/qmlprojectmanager')
| -rw-r--r-- | src/plugins/qmlprojectmanager/qmlprojectapplicationwizard.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/plugins/qmlprojectmanager/qmlprojectapplicationwizard.cpp b/src/plugins/qmlprojectmanager/qmlprojectapplicationwizard.cpp index f2f27e9aa4..30a9003d31 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectapplicationwizard.cpp +++ b/src/plugins/qmlprojectmanager/qmlprojectapplicationwizard.cpp @@ -93,11 +93,9 @@ QWizard *QmlProjectApplicationWizard::createWizardDialog(QWidget *parent, { QmlProjectApplicationWizardDialog *wizard = new QmlProjectApplicationWizardDialog(parent, wizardDialogParameters); - wizard->setPath(wizardDialogParameters.defaultPath()); wizard->setProjectName(QmlProjectApplicationWizardDialog::uniqueProjectName(wizardDialogParameters.defaultPath())); - foreach (QWizardPage *p, wizardDialogParameters.extensionPages()) - BaseFileWizard::applyExtensionPageShortTitle(wizard, wizard->addPage(p)); + wizard->addExtensionPages(wizardDialogParameters.extensionPages()); return wizard; } |