diff options
| author | Christian Kandeler <christian.kandeler@digia.com> | 2014-07-01 11:08:26 +0200 |
|---|---|---|
| committer | hjk <hjk121@nokiamail.com> | 2014-07-01 11:52:08 +0200 |
| commit | 93304df0381cbeabf4c8435aec0ad55fbc7f8fe7 (patch) | |
| tree | 7cbe348b1e3f88041b7e159aa335031e2c41bfc8 /src/plugins/qmlprofiler | |
| parent | 139449239c7cd63ab933d13e20b37cd717a45fe7 (diff) | |
| download | qt-creator-93304df0381cbeabf4c8435aec0ad55fbc7f8fe7.tar.gz | |
Always pass Core::Id by value.
Currently we pass in some places by value, elsewhere by const ref and
for some weird reason also by const value in a lot of places. The latter
is particularly annoying, as it is also used in interfaces and therefore
forces all implementors to do the same, since leaving the "const" off is
causing compiler warnings with MSVC.
Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
Reviewed-by: hjk <hjk121@nokiamail.com>
Diffstat (limited to 'src/plugins/qmlprofiler')
| -rw-r--r-- | src/plugins/qmlprofiler/qmlprofilerattachdialog.cpp | 2 | ||||
| -rw-r--r-- | src/plugins/qmlprofiler/qmlprofilerattachdialog.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/qmlprofiler/qmlprofilerattachdialog.cpp b/src/plugins/qmlprofiler/qmlprofilerattachdialog.cpp index 9727d12d40..459acd91d9 100644 --- a/src/plugins/qmlprofiler/qmlprofilerattachdialog.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerattachdialog.cpp @@ -100,7 +100,7 @@ ProjectExplorer::Kit *QmlProfilerAttachDialog::kit() const return d->kitChooser->currentKit(); } -void QmlProfilerAttachDialog::setKitId(const Core::Id &id) +void QmlProfilerAttachDialog::setKitId(Core::Id id) { d->kitChooser->setCurrentKitId(id); } diff --git a/src/plugins/qmlprofiler/qmlprofilerattachdialog.h b/src/plugins/qmlprofiler/qmlprofilerattachdialog.h index ebb0795041..1f80b4240f 100644 --- a/src/plugins/qmlprofiler/qmlprofilerattachdialog.h +++ b/src/plugins/qmlprofiler/qmlprofilerattachdialog.h @@ -51,7 +51,7 @@ public: void setPort(const int port); ProjectExplorer::Kit *kit() const; - void setKitId(const Core::Id &id); + void setKitId(Core::Id id); private: QmlProfilerAttachDialogPrivate *d; |