diff options
author | Ulf Hermann <ulf.hermann@qt.io> | 2018-03-23 14:20:46 +0100 |
---|---|---|
committer | Ulf Hermann <ulf.hermann@qt.io> | 2018-04-16 14:16:03 +0000 |
commit | b135306d9f8ff352f3ed41891cee2cc3cc8a4c6d (patch) | |
tree | 89d881130929ff6b9dc23739166b5e4997446203 /src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.cpp | |
parent | 4aa432bb9a806843b40369316155df7393f6e195 (diff) | |
download | qt-creator-b135306d9f8ff352f3ed41891cee2cc3cc8a4c6d.tar.gz |
QmlProfiler: Remove now-unused members from statistics
Change-Id: Ibf56f405dc51a82d0f56ab300905b1137375d5c0
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Diffstat (limited to 'src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.cpp')
-rw-r--r-- | src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.cpp | 70 |
1 files changed, 4 insertions, 66 deletions
diff --git a/src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.cpp b/src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.cpp index 72525fdc9c..c7e32ec975 100644 --- a/src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.cpp @@ -30,15 +30,11 @@ #include <utils/algorithm.h> #include <utils/qtcassert.h> -#include <QHash> -#include <QSet> -#include <QString> - #include <functional> namespace QmlProfiler { -QString QmlProfilerStatisticsModel::nameForType(RangeType typeNumber) +QString nameForType(RangeType typeNumber) { switch (typeNumber) { case Painting: return QmlProfilerStatisticsModel::tr("Painting"); @@ -125,22 +121,6 @@ bool QmlProfilerStatisticsModel::isRestrictedToRange() const return m_modelManager->isRestrictedToRange(); } -const QVector<QmlProfilerStatisticsModel::QmlEventStats> & -QmlProfilerStatisticsModel::getData() const -{ - return m_data; -} - -const QVector<QmlEventType> &QmlProfilerStatisticsModel::getTypes() const -{ - return m_modelManager->eventTypes(); -} - -const QHash<int, QString> &QmlProfilerStatisticsModel::getNotes() const -{ - return m_notes; -} - QStringList QmlProfilerStatisticsModel::details(int typeIndex) const { QString data; @@ -447,8 +427,6 @@ void QmlProfilerStatisticsModel::notesChanged(int typeIndex) emit dataChanged(index(typeIndex, 0), index(typeIndex, MainDetails), noteRoles); } } - - emit notesAvailable(typeIndex); } void QmlProfilerStatisticsModel::loadEvent(const QmlEvent &event, const QmlEventType &type) @@ -502,19 +480,11 @@ void QmlProfilerStatisticsModel::loadEvent(const QmlEvent &event, const QmlEvent m_callersModel->loadEvent(type.rangeType(), event, isRecursive); } - void QmlProfilerStatisticsModel::finalize() { for (QmlEventStats &stats : m_data) stats.finalize(); endResetModel(); - - emit dataAvailable(); -} - -int QmlProfilerStatisticsModel::count() const -{ - return m_data.count(); } QmlProfilerStatisticsRelativesModel::QmlProfilerStatisticsRelativesModel( @@ -526,28 +496,6 @@ QmlProfilerStatisticsRelativesModel::QmlProfilerStatisticsRelativesModel( QTC_CHECK(modelManager); QTC_CHECK(statisticsModel); statisticsModel->setRelativesModel(this, relation); - - // Load the child models whenever the parent model is done to get the filtering for JS/QML - // right. - connect(statisticsModel, &QmlProfilerStatisticsModel::dataAvailable, - this, &QmlProfilerStatisticsRelativesModel::dataAvailable); -} - -const QVector<QmlProfilerStatisticsRelativesModel::QmlStatisticsRelativesData> & -QmlProfilerStatisticsRelativesModel::getData(int typeId) const -{ - auto it = m_data.find(typeId); - if (it != m_data.end()) { - return it.value(); - } else { - static const QVector<QmlStatisticsRelativesData> emptyVector; - return emptyVector; - } -} - -const QVector<QmlEventType> &QmlProfilerStatisticsRelativesModel::getTypes() const -{ - return m_modelManager->eventTypes(); } bool operator<(const QmlProfilerStatisticsRelativesModel::QmlStatisticsRelativesData &a, @@ -597,11 +545,6 @@ void QmlProfilerStatisticsRelativesModel::loadEvent(RangeType type, const QmlEve } } -QmlProfilerStatisticsRelation QmlProfilerStatisticsRelativesModel::relation() const -{ - return m_relation; -} - int QmlProfilerStatisticsRelativesModel::rowCount(const QModelIndex &parent) const { return parent.isValid() ? 0 : m_data[m_relativeTypeIndex].count(); @@ -687,7 +630,7 @@ QVariant QmlProfilerStatisticsRelativesModel::data(const QModelIndex &index, int case RelativeLocation: return type.displayName().isEmpty() ? tr("<bytecode>") : type.displayName(); case RelativeType: - return QmlProfilerStatisticsModel::nameForType(type.rangeType()); + return nameForType(type.rangeType()); case RelativeTotalTime: return Timeline::formatTime(stats.duration); case RelativeCallCount: @@ -711,7 +654,7 @@ QVariant QmlProfilerStatisticsRelativesModel::headerData(int section, Qt::Orient switch (section) { case RelativeLocation: - return relation() == QmlProfilerStatisticsCallees ? tr("Callee") : tr("Caller"); + return m_relation == QmlProfilerStatisticsCallees ? tr("Callee") : tr("Caller"); case RelativeType: return tr("Type"); case RelativeTotalTime: @@ -719,7 +662,7 @@ QVariant QmlProfilerStatisticsRelativesModel::headerData(int section, Qt::Orient case RelativeCallCount: return tr("Calls"); case RelativeDetails: - return relation() == QmlProfilerStatisticsCallees ? tr("Callee Description") + return m_relation == QmlProfilerStatisticsCallees ? tr("Callee Description") : tr("Caller Description"); case MaxRelativeField: default: @@ -742,11 +685,6 @@ bool QmlProfilerStatisticsRelativesModel::setData(const QModelIndex &index, cons } } -int QmlProfilerStatisticsRelativesModel::count() const -{ - return m_data.count(); -} - void QmlProfilerStatisticsRelativesModel::clear() { beginResetModel(); |