diff options
| author | Daniel Teske <daniel.teske@nokia.com> | 2012-05-02 13:10:14 +0200 |
|---|---|---|
| committer | hjk <qthjk@ovi.com> | 2012-05-02 13:18:50 +0200 |
| commit | 1c1736944fdbd1b6b8e783e217d326c310fa7080 (patch) | |
| tree | e1b521dc630822244d9bc941791543d11b24df1c /src/plugins/projectexplorer/taskhub.cpp | |
| parent | f3d49692eb61579e5fe519c4ac61089eec5cc547 (diff) | |
| download | qt-creator-1c1736944fdbd1b6b8e783e217d326c310fa7080.tar.gz | |
Make ITextMark::widthFactor() and visible() non virtual
Instead make them simple properties of ITextMark
The BaseTextMark destructor calls removeMark(this), at which point the
virtual functions are already returning a possibly wrong value.
Change-Id: Ic5b58dc0bc285a9618f4b9967ecfe941d75883c7
Reviewed-by: hjk <qthjk@ovi.com>
Diffstat (limited to 'src/plugins/projectexplorer/taskhub.cpp')
| -rw-r--r-- | src/plugins/projectexplorer/taskhub.cpp | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/plugins/projectexplorer/taskhub.cpp b/src/plugins/projectexplorer/taskhub.cpp index 39ce6a4bd1..c726f62556 100644 --- a/src/plugins/projectexplorer/taskhub.cpp +++ b/src/plugins/projectexplorer/taskhub.cpp @@ -42,8 +42,10 @@ class TaskMark : public TextEditor::BaseTextMark { public: TaskMark(unsigned int id, const QString &fileName, int lineNumber, bool visible) - : BaseTextMark(fileName, lineNumber), m_id(id), m_visible(visible) - {} + : BaseTextMark(fileName, lineNumber), m_id(id) + { + setVisible(visible); + } bool clickable() const; void clicked(); @@ -51,7 +53,6 @@ public: void updateFileName(const QString &fileName); void updateLineNumber(int lineNumber); void removedFromEditor(); - bool visible() const; private: unsigned int m_id; bool m_visible; @@ -74,11 +75,6 @@ void TaskMark::removedFromEditor() ProjectExplorerPlugin::instance()->taskHub()->updateTaskLineNumber(m_id, -1); } -bool TaskMark::visible() const -{ - return m_visible; -} - bool TaskMark::clickable() const { return true; |