Introduce an enumeration for toolchain autodetection.

Replace boolean "autodetect" by an enumeration with a value
AutoDetectionFromSettings indicating whether the Autodetection
originates from a settings file. Enable the "Remove" button for
those cases.

Currently, there is no way to remove toolchains that were once
autodetected and are no longer present. This happens for example
when working in different MinGW environments, which then
clutter up the toolchain options page and dramatically slow
down the options page opening since gcc is launched to query
the flags, etc.

Change-Id: I731168d8694fe56f60d909f9779f83cffa55fd44
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/src/plugins/projectexplorer/gcctoolchain.h b/src/plugins/projectexplorer/gcctoolchain.h
index 093e2c6c30..64dda77a30 100644
--- a/src/plugins/projectexplorer/gcctoolchain.h
+++ b/src/plugins/projectexplorer/gcctoolchain.h
@@ -55,7 +55,7 @@ class LinuxIccToolChainFactory;
 class PROJECTEXPLORER_EXPORT GccToolChain : public ToolChain
 {
 public:
-    GccToolChain(const QString &id, bool autodetect);
+    GccToolChain(const QString &id, Detection d);
     QString type() const;
     QString typeDisplayName() const;
     Abi targetAbi() const;
@@ -124,7 +124,7 @@ protected:
     };
 
 private:
-    GccToolChain(bool autodetect);
+    explicit GccToolChain(Detection d);
 
     void updateSupportedAbis() const;
 
@@ -166,7 +166,7 @@ protected:
     virtual CompilerFlags defaultCompilerFlags() const;
 
 private:
-    ClangToolChain(bool autodetect);
+    explicit ClangToolChain(Detection d);
 
     friend class Internal::ClangToolChainFactory;
     friend class ToolChainFactory;
@@ -188,7 +188,7 @@ public:
     QList<Utils::FileName> suggestedMkspecList() const;
 
 private:
-    MingwToolChain(bool autodetect);
+    explicit MingwToolChain(Detection d);
 
     friend class Internal::MingwToolChainFactory;
     friend class ToolChainFactory;
@@ -212,7 +212,7 @@ public:
     QList<Utils::FileName> suggestedMkspecList() const;
 
 private:
-    LinuxIccToolChain(bool autodetect);
+    explicit LinuxIccToolChain(Detection d);
 
     friend class Internal::LinuxIccToolChainFactory;
     friend class ToolChainFactory;