diff options
author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2015-04-14 22:30:46 +0300 |
---|---|---|
committer | Tobias Hunger <tobias.hunger@theqtcompany.com> | 2015-04-15 12:42:46 +0000 |
commit | a79df8e1e78384745e68d365b23cc77656c060aa (patch) | |
tree | c81b132422e64525827696cf574ce4520c440c56 /src/plugins/perforce | |
parent | 5a2b5036abdfb9131acd7e4618e2d8e13d487d63 (diff) | |
download | qt-creator-a79df8e1e78384745e68d365b23cc77656c060aa.tar.gz |
Utils: Make SynchronousProcess use second based timeouts
Change-Id: Ie2de2359225017cae7181bee0df17542fa36efd8
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Diffstat (limited to 'src/plugins/perforce')
-rw-r--r-- | src/plugins/perforce/perforceplugin.cpp | 14 | ||||
-rw-r--r-- | src/plugins/perforce/perforcesettings.h | 2 |
2 files changed, 8 insertions, 8 deletions
diff --git a/src/plugins/perforce/perforceplugin.cpp b/src/plugins/perforce/perforceplugin.cpp index eb594dbfe9..e88ca24aee 100644 --- a/src/plugins/perforce/perforceplugin.cpp +++ b/src/plugins/perforce/perforceplugin.cpp @@ -991,9 +991,9 @@ static inline QString msgNotStarted(const QString &cmd) return PerforcePlugin::tr("Could not start perforce \"%1\". Please check your settings in the preferences.").arg(cmd); } -static inline QString msgTimeout(int timeOut) +static inline QString msgTimeout(int timeOutS) { - return PerforcePlugin::tr("Perforce did not respond within timeout limit (%1 ms).").arg(timeOut ); + return PerforcePlugin::tr("Perforce did not respond within timeout limit (%1 s).").arg(timeOutS); } static inline QString msgCrash() @@ -1018,8 +1018,8 @@ PerforceResponse PerforcePlugin::synchronousProcess(const QString &workingDir, VcsOutputWindow *outputWindow = VcsOutputWindow::instance(); // Run, connect stderr to the output window SynchronousProcess process; - const int timeOut = (flags & LongTimeOut) ? settings().longTimeOutMS() : settings().timeOutMS(); - process.setTimeout(timeOut); + const int timeOutS = (flags & LongTimeOut) ? settings().longTimeOutS() : settings().timeOutS(); + process.setTimeoutS(timeOutS); process.setCodec(outputCodec); if (flags & OverrideDiffEnvironment) process.setProcessEnvironment(overrideDiffEnvironmentVariable()); @@ -1116,11 +1116,11 @@ PerforceResponse PerforcePlugin::fullySynchronousProcess(const QString &workingD QByteArray stdOut; QByteArray stdErr; - const int timeOut = (flags & LongTimeOut) ? settings().longTimeOutMS() : settings().timeOutMS(); - if (!SynchronousProcess::readDataFromProcess(process, timeOut, &stdOut, &stdErr, true)) { + const int timeOutS = (flags & LongTimeOut) ? settings().longTimeOutS() : settings().timeOutS(); + if (!SynchronousProcess::readDataFromProcess(process, timeOutS, &stdOut, &stdErr, true)) { SynchronousProcess::stopProcess(process); response.error = true; - response.message = msgTimeout(timeOut); + response.message = msgTimeout(timeOutS); return response; } if (process.exitStatus() != QProcess::NormalExit) { diff --git a/src/plugins/perforce/perforcesettings.h b/src/plugins/perforce/perforcesettings.h index a8cc9cd0ab..db661608b0 100644 --- a/src/plugins/perforce/perforcesettings.h +++ b/src/plugins/perforce/perforcesettings.h @@ -103,8 +103,8 @@ public: Settings settings() const; inline int timeOutS() const { return m_settings.timeOutS; } + inline int longTimeOutS() const { return m_settings.timeOutS * 10; } inline int timeOutMS() const { return m_settings.timeOutS * 1000; } - inline int longTimeOutMS() const { return m_settings.timeOutS * 10000; } inline int logCount() const { return m_settings.logCount; } |