diff options
author | Christian Kandeler <christian.kandeler@digia.com> | 2014-07-01 11:08:26 +0200 |
---|---|---|
committer | hjk <hjk121@nokiamail.com> | 2014-07-01 11:52:08 +0200 |
commit | 93304df0381cbeabf4c8435aec0ad55fbc7f8fe7 (patch) | |
tree | 7cbe348b1e3f88041b7e159aa335031e2c41bfc8 /src/plugins/ios/iosdeployconfiguration.h | |
parent | 139449239c7cd63ab933d13e20b37cd717a45fe7 (diff) | |
download | qt-creator-93304df0381cbeabf4c8435aec0ad55fbc7f8fe7.tar.gz |
Always pass Core::Id by value.
Currently we pass in some places by value, elsewhere by const ref and
for some weird reason also by const value in a lot of places. The latter
is particularly annoying, as it is also used in interfaces and therefore
forces all implementors to do the same, since leaving the "const" off is
causing compiler warnings with MSVC.
Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
Reviewed-by: hjk <hjk121@nokiamail.com>
Diffstat (limited to 'src/plugins/ios/iosdeployconfiguration.h')
-rw-r--r-- | src/plugins/ios/iosdeployconfiguration.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/ios/iosdeployconfiguration.h b/src/plugins/ios/iosdeployconfiguration.h index c3a4541667..e3f90a9283 100644 --- a/src/plugins/ios/iosdeployconfiguration.h +++ b/src/plugins/ios/iosdeployconfiguration.h @@ -59,8 +59,8 @@ class IosDeployConfigurationFactory : public ProjectExplorer::DeployConfiguratio public: explicit IosDeployConfigurationFactory(QObject *parent = 0); - bool canCreate(ProjectExplorer::Target *parent, const Core::Id id) const QTC_OVERRIDE; - ProjectExplorer::DeployConfiguration *create(ProjectExplorer::Target *parent, const Core::Id id) QTC_OVERRIDE; + bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const QTC_OVERRIDE; + ProjectExplorer::DeployConfiguration *create(ProjectExplorer::Target *parent, Core::Id id) QTC_OVERRIDE; bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const QTC_OVERRIDE; ProjectExplorer::DeployConfiguration *restore(ProjectExplorer::Target *parent, const QVariantMap &map) QTC_OVERRIDE; @@ -71,7 +71,7 @@ public: QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent) const QTC_OVERRIDE; // used to translate the ids to names to display to the user - QString displayNameForId(const Core::Id id) const QTC_OVERRIDE; + QString displayNameForId(Core::Id id) const QTC_OVERRIDE; private: bool canHandle(ProjectExplorer::Target *parent) const QTC_OVERRIDE; |