Help: Fix that bookmarks were not restored

We have to make sure that the help engine is properly set up before
trying to read the bookmark data.

Change-Id: Id57cce5f538472eeac17b39a3640bf2ed77fa56a
Task-number: QTCREATORBUG-14106
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

2 files changed, 3 insertions, 3 deletions

diff --git a/src/plugins/help/helpplugin.cpp b/src/plugins/help/helpplugin.cpp
index 5915c9f102..2ad2dbcbe0 100644
--- a/src/plugins/help/helpplugin.cpp
+++ b/src/plugins/help/helpplugin.cpp
@@ -30,6 +30,7 @@
 
 #include "helpplugin.h"
 
+#include "bookmarkmanager.h"
 #include "centralwidget.h"
 #include "docsettingspage.h"
 #include "filtersettingspage.h"
@@ -668,6 +669,7 @@ void HelpPlugin::doSetupIfNeeded()
         resetFilter();
         m_setupNeeded = false;
         OpenPagesManager::instance().setupInitialPages();
+        LocalHelpManager::bookmarkManager().setupBookmarkModels();
     }
 }
 
diff --git a/src/plugins/help/localhelpmanager.cpp b/src/plugins/help/localhelpmanager.cpp
index 3603d6fbb8..96508149e7 100644
--- a/src/plugins/help/localhelpmanager.cpp
+++ b/src/plugins/help/localhelpmanager.cpp
@@ -140,10 +140,8 @@ BookmarkManager& LocalHelpManager::bookmarkManager()
 {
     if (!m_bookmarkManager) {
         QMutexLocker _(&m_bkmarkMutex);
-        if (!m_bookmarkManager) {
+        if (!m_bookmarkManager)
             m_bookmarkManager = new BookmarkManager;
-            m_bookmarkManager->setupBookmarkModels();
-        }
     }
     return *m_bookmarkManager;
 }