summaryrefslogtreecommitdiff
path: root/src/plugins/git
diff options
context:
space:
mode:
authorOrgad Shaneh <orgads@gmail.com>2013-08-06 18:26:31 +0200
committerOrgad Shaneh <orgads@gmail.com>2013-08-06 18:27:09 +0200
commit7c5b19ebf4f4909a452ee78abe79e60e4d12a2cf (patch)
tree35fdad12a42169e1a6627a0c5474b0c6c70fe944 /src/plugins/git
parentfe25ae993593a79a232767f17a3014e701831a9c (diff)
downloadqt-creator-7c5b19ebf4f4909a452ee78abe79e60e4d12a2cf.tar.gz
Revert "Git: Use a single filename for log"
Breaks compilation This reverts commit a05ea7113368a807057410b84d7ef21409d818af Change-Id: I713f06a1fe1ff24f4721cda082fb732dc3f5c270 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/git')
-rw-r--r--src/plugins/git/gitclient.cpp27
-rw-r--r--src/plugins/git/gitclient.h2
-rw-r--r--src/plugins/git/gitplugin.cpp4
3 files changed, 17 insertions, 16 deletions
diff --git a/src/plugins/git/gitclient.cpp b/src/plugins/git/gitclient.cpp
index 8b89f7f7be..3ad47bd620 100644
--- a/src/plugins/git/gitclient.cpp
+++ b/src/plugins/git/gitclient.cpp
@@ -637,7 +637,7 @@ public:
const QString &directory,
bool enableAnnotationContextMenu,
const QStringList &args,
- const QString &fileName) :
+ const QStringList &fileNames) :
BaseGitDiffArgumentsWidget(client, directory, args),
m_client(client),
m_workingDirectory(directory),
@@ -657,24 +657,24 @@ public:
QToolButton *graphButton = addToggleButton(graphArguments, tr("Graph"),
tr("Show textual graph log."));
mapSetting(graphButton, m_client->settings()->boolPointer(GitSettings::graphLogKey));
- setFileName(fileName);
+ setFileNames(fileNames);
}
- void setFileName(const QString &fileNames)
+ void setFileNames(const QStringList &fileNames)
{
- m_fileName = fileNames;
+ m_fileNames = fileNames;
}
void executeCommand()
{
- m_client->log(m_workingDirectory, m_fileName, m_enableAnnotationContextMenu, baseArguments());
+ m_client->log(m_workingDirectory, m_fileNames, m_enableAnnotationContextMenu, baseArguments());
}
private:
GitClient *m_client;
QString m_workingDirectory;
bool m_enableAnnotationContextMenu;
- QString m_fileName;
+ QStringList m_fileNames;
};
class ConflictHandler : public QObject
@@ -1113,19 +1113,20 @@ void GitClient::status(const QString &workingDirectory)
Qt::QueuedConnection);
}
-void GitClient::log(const QString &workingDirectory, const QString &fileName,
+void GitClient::log(const QString &workingDirectory, const QStringList &fileNames,
bool enableAnnotationContextMenu, const QStringList &args)
{
- const QString msgArg = fileName.isEmpty() ? workingDirectory : fileName;
+ const QString msgArg = fileNames.empty() ? workingDirectory :
+ fileNames.join(QLatin1String(", "));
const QString title = tr("Git Log \"%1\"").arg(msgArg);
const Core::Id editorId = Git::Constants::GIT_LOG_EDITOR_ID;
- const QString sourceFile = VcsBase::VcsBaseEditorWidget::getSource(workingDirectory, fileName);
+ const QString sourceFile = VcsBase::VcsBaseEditorWidget::getSource(workingDirectory, fileNames);
VcsBase::VcsBaseEditorWidget *editor = findExistingVCSEditor("logFileName", sourceFile);
if (!editor)
editor = createVcsEditor(editorId, title, sourceFile, CodecLogOutput, "logFileName", sourceFile,
new GitLogArgumentsWidget(this, workingDirectory,
enableAnnotationContextMenu,
- args, fileName));
+ args, fileNames));
editor->setFileLogAnnotateEnabled(enableAnnotationContextMenu);
editor->setDiffBaseDirectory(workingDirectory);
@@ -1139,13 +1140,13 @@ void GitClient::log(const QString &workingDirectory, const QString &fileName,
GitLogArgumentsWidget *argWidget = qobject_cast<GitLogArgumentsWidget *>(editor->configurationWidget());
argWidget->setBaseArguments(args);
- argWidget->setFileName(fileName);
+ argWidget->setFileNames(fileNames);
QStringList userArgs = argWidget->arguments();
arguments.append(userArgs);
- if (!fileName.isEmpty())
- arguments << QLatin1String("--") << fileName;
+ if (!fileNames.isEmpty())
+ arguments << QLatin1String("--") << fileNames;
executeGit(workingDirectory, arguments, editor);
}
diff --git a/src/plugins/git/gitclient.h b/src/plugins/git/gitclient.h
index fa7ac9a921..47e27ccf5b 100644
--- a/src/plugins/git/gitclient.h
+++ b/src/plugins/git/gitclient.h
@@ -146,7 +146,7 @@ public:
void merge(const QString &workingDirectory, const QStringList &unmergedFileNames = QStringList());
void status(const QString &workingDirectory);
- void log(const QString &workingDirectory, const QString &fileName = QString(),
+ void log(const QString &workingDirectory, const QStringList &fileNames = QStringList(),
bool enableAnnotationContextMenu = false, const QStringList &args = QStringList());
void blame(const QString &workingDirectory, const QStringList &args, const QString &fileName,
const QString &revision = QString(), int lineNumber = -1);
diff --git a/src/plugins/git/gitplugin.cpp b/src/plugins/git/gitplugin.cpp
index 1692b780d2..6801a97390 100644
--- a/src/plugins/git/gitplugin.cpp
+++ b/src/plugins/git/gitplugin.cpp
@@ -744,7 +744,7 @@ void GitPlugin::diffCurrentProject()
{
const VcsBase::VcsBasePluginState state = currentState();
QTC_ASSERT(state.hasProject(), return);
- m_gitClient->diff(state.currentProjectTopLevel(), QStringList(state.relativeCurrentProject()));
+ m_gitClient->diff(state.currentProjectTopLevel(), state.relativeCurrentProject());
}
void GitPlugin::diffRepository()
@@ -758,7 +758,7 @@ void GitPlugin::logFile()
{
const VcsBase::VcsBasePluginState state = currentState();
QTC_ASSERT(state.hasFile(), return);
- m_gitClient->log(state.currentFileTopLevel(), state.relativeCurrentFile(), true);
+ m_gitClient->log(state.currentFileTopLevel(), QStringList(state.relativeCurrentFile()), true);
}
void GitPlugin::blameFile()