diff options
author | Thiago Macieira <thiago.macieira@intel.com> | 2013-12-05 23:29:37 -0800 |
---|---|---|
committer | Thiago Macieira <thiago.macieira@intel.com> | 2014-01-10 15:40:22 +0100 |
commit | 58a4e601ffa1262841534c547bf8bb7cd075c3dd (patch) | |
tree | cbac4603f2d8cab1ad050b2525d2cc91a477f20d /src/plugins/debugger | |
parent | 1ff3a8287d7f830de362d49b4042544c6af3a754 (diff) | |
download | qt-creator-58a4e601ffa1262841534c547bf8bb7cd075c3dd.tar.gz |
Fix change-of-sign warning found by ICC
-1 is not a valid unsigned value.
registerhandler.cpp(354): warning #68: integer conversion resulted in a change of sign
return createIndex(row, col, TopLevelId);
^
Change-Id: I41935255704f19724d6cec16ea470e2f8f8a16a1
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
Diffstat (limited to 'src/plugins/debugger')
-rw-r--r-- | src/plugins/debugger/debuggerprotocol.cpp | 4 | ||||
-rw-r--r-- | src/plugins/debugger/qml/qmllivetextpreview.cpp | 2 | ||||
-rw-r--r-- | src/plugins/debugger/registerhandler.cpp | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/plugins/debugger/debuggerprotocol.cpp b/src/plugins/debugger/debuggerprotocol.cpp index 5e5ab73821..086e47fae5 100644 --- a/src/plugins/debugger/debuggerprotocol.cpp +++ b/src/plugins/debugger/debuggerprotocol.cpp @@ -50,7 +50,7 @@ uchar fromhex(uchar c) return 10 + c - 'a'; if (c >= 'A' && c <= 'Z') return 10 + c - 'A'; - return -1; + return UCHAR_MAX; } void skipCommas(const char *&from, const char *to) @@ -141,7 +141,7 @@ QByteArray GdbMi::parseCString(const char *&from, const char *to) uchar prod = 0; while (true) { uchar val = fromhex(c); - if (val == uchar(-1)) + if (val == UCHAR_MAX) break; prod = prod * 16 + val; if (++chars == 3 || src == end) diff --git a/src/plugins/debugger/qml/qmllivetextpreview.cpp b/src/plugins/debugger/qml/qmllivetextpreview.cpp index f01a04738c..4379aca42b 100644 --- a/src/plugins/debugger/qml/qmllivetextpreview.cpp +++ b/src/plugins/debugger/qml/qmllivetextpreview.cpp @@ -642,7 +642,7 @@ void QmlLiveTextPreview::editorContentsChanged() void QmlLiveTextPreview::onAutomaticUpdateFailed() { - showSyncWarning(AutomaticUpdateFailed, QString(), -1, -1); + showSyncWarning(AutomaticUpdateFailed, QString(), UINT_MAX, UINT_MAX); } QList<int> QmlLiveTextPreview::objectReferencesForOffset(quint32 offset) diff --git a/src/plugins/debugger/registerhandler.cpp b/src/plugins/debugger/registerhandler.cpp index 71904f1ac4..4b068a9cad 100644 --- a/src/plugins/debugger/registerhandler.cpp +++ b/src/plugins/debugger/registerhandler.cpp @@ -293,7 +293,7 @@ static int bitWidthFromType(int type, int subType) return 0; } -static const int TopLevelId = -1; +static const uint TopLevelId = UINT_MAX; static bool isTopLevelItem(const QModelIndex &index) { return quintptr(index.internalId()) == quintptr(TopLevelId); |