diff options
| author | hjk <hjk@qt.io> | 2018-11-13 09:20:24 +0100 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2018-11-13 09:18:29 +0000 |
| commit | 0ee07ae2adcd0691f68637910259c086c320b62c (patch) | |
| tree | b2ba9a2c1e11f4fd5347a298bfaca1b902fce25f /src/plugins/debugger/debuggerengine.cpp | |
| parent | f876a71fa1ddd9cd385c13f8ef55e153127c67e6 (diff) | |
| download | qt-creator-0ee07ae2adcd0691f68637910259c086c320b62c.tar.gz | |
Debugger: Make validateExecutable a validateRunParameters
Gets rid of the odd and otherwise unused
DebuggerEngine::mutableRunParameters() function.
Change-Id: Ib0861432e7c61072db2968acf2f36c7f2d56c89a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/debugger/debuggerengine.cpp')
| -rw-r--r-- | src/plugins/debugger/debuggerengine.cpp | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/src/plugins/debugger/debuggerengine.cpp b/src/plugins/debugger/debuggerengine.cpp index 0e026ba358..a0e97ec8c9 100644 --- a/src/plugins/debugger/debuggerengine.cpp +++ b/src/plugins/debugger/debuggerengine.cpp @@ -1011,7 +1011,7 @@ void DebuggerEngine::setRunTool(DebuggerRunTool *runTool) d->m_device = d->m_runParameters.inferior.device; d->m_terminalRunner = runTool->terminalRunner(); - validateExecutable(); + validateRunParameters(d->m_runParameters); d->setupViews(); } @@ -1080,11 +1080,6 @@ const DebuggerRunParameters &DebuggerEngine::runParameters() const return d->m_runParameters; } -DebuggerRunParameters &DebuggerEngine::mutableRunParameters() const -{ - return d->m_runParameters; -} - IDevice::ConstPtr DebuggerEngine::device() const { return d->m_device; @@ -2604,9 +2599,8 @@ Context CppDebuggerEngine::languageContext() const return Context(Constants::C_CPPDEBUGGER); } -void CppDebuggerEngine::validateExecutable() +void CppDebuggerEngine::validateRunParameters(DebuggerRunParameters &rp) { - DebuggerRunParameters &rp = mutableRunParameters(); const bool warnOnRelease = boolSetting(WarnOnReleaseBuilds) && rp.toolChainAbi.osFlavor() != Abi::AndroidLinuxFlavor; bool warnOnInappropriateDebugger = false; QString detailedWarning; |