Core: Fix exit strategy

Fix break condition for a while loop and add some "const".

Change-Id: I62abe4701d6d919428266772867f4bc6c7c43759
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/src/plugins/coreplugin/toolsettings.cpp b/src/plugins/coreplugin/toolsettings.cpp
index 3da1264020..1804341526 100644
--- a/src/plugins/coreplugin/toolsettings.cpp
+++ b/src/plugins/coreplugin/toolsettings.cpp
@@ -67,20 +67,20 @@ QWidget *ToolSettings::widget()
 
 static QString getUserFilePath(const QString &proposalFileName)
 {
-    QDir resourceDir(ICore::userResourcePath());
+    const QDir resourceDir(ICore::userResourcePath());
     if (!resourceDir.exists(QLatin1String("externaltools")))
         resourceDir.mkpath(QLatin1String("externaltools"));
-    QFileInfo fi(proposalFileName);
+    const QFileInfo fi(proposalFileName);
     const QString &suffix = QLatin1String(".") + fi.completeSuffix();
     const QString &newFilePath = ICore::userResourcePath()
             + QLatin1String("/externaltools/") + fi.baseName();
     int count = 0;
     QString tryPath = newFilePath + suffix;
     while (QFile::exists(tryPath)) {
-        if (count > 15)
+        if (++count > 15)
             return QString();
         // add random number
-        int number = qrand() % 1000;
+        const int number = qrand() % 1000;
         tryPath = newFilePath + QString::number(number) + suffix;
     }
     return tryPath;