diff options
| author | hjk <hjk@qt.io> | 2017-05-09 10:25:11 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2017-05-15 14:35:03 +0000 |
| commit | 89f02cba2ca65f84d99b0b35f555da024f3e2234 (patch) | |
| tree | 408bd4b2da13e00227697f871cefbf1ea9c4ab98 /src/plugins/clangstaticanalyzer | |
| parent | 9b93d5a330a4898d12ce99414a51d1bd6cda51ec (diff) | |
| download | qt-creator-89f02cba2ca65f84d99b0b35f555da024f3e2234.tar.gz | |
ProjectExplorer: Split Target and ToolRunners into smaller tasks
This increases re-usability of activities like 'port gathering',
and makes their use less dependent on actual device implementations.
Change-Id: I017cb74874f2b38c487ba2d03906a675d5618647
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/clangstaticanalyzer')
3 files changed, 5 insertions, 4 deletions
diff --git a/src/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp b/src/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp index 37721ec772..43fdf32bc0 100644 --- a/src/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp +++ b/src/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp @@ -71,8 +71,9 @@ namespace Internal { ClangStaticAnalyzerToolRunner::ClangStaticAnalyzerToolRunner(RunControl *runControl, QString *errorMessage) - : ToolRunner(runControl) + : RunWorker(runControl) { + setDisplayName("ClangStaticAnalyzerRunner"); runControl->setDisplayName(tr("Clang Static Analyzer")); runControl->setIcon(ProjectExplorer::Icons::ANALYZER_START_SMALL_TOOLBAR); runControl->setSupportsReRunning(false); @@ -585,7 +586,7 @@ void ClangStaticAnalyzerToolRunner::start() return; } - reportSuccess(); + reportStarted(); while (m_runners.size() < parallelRuns && !m_unitsToProcess.isEmpty()) analyzeNextFile(); diff --git a/src/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.h b/src/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.h index 28d7600493..3c6b4267d7 100644 --- a/src/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.h +++ b/src/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.h @@ -47,7 +47,7 @@ struct AnalyzeUnit { }; typedef QList<AnalyzeUnit> AnalyzeUnits; -class ClangStaticAnalyzerToolRunner : public ProjectExplorer::ToolRunner +class ClangStaticAnalyzerToolRunner : public ProjectExplorer::RunWorker { Q_OBJECT diff --git a/src/plugins/clangstaticanalyzer/clangstaticanalyzertool.cpp b/src/plugins/clangstaticanalyzer/clangstaticanalyzertool.cpp index e1e7c2adef..c8f1f6c8ba 100644 --- a/src/plugins/clangstaticanalyzer/clangstaticanalyzertool.cpp +++ b/src/plugins/clangstaticanalyzer/clangstaticanalyzertool.cpp @@ -145,7 +145,7 @@ ClangStaticAnalyzerTool::ClangStaticAnalyzerTool() {{ClangStaticAnalyzerDockId, m_diagnosticView, {}, Perspective::SplitVertical}} )); - Debugger::registerAction(Constants::CLANGSTATICANALYZER_RUN_MODE, {}); + //Debugger::registerAction(Constants::CLANGSTATICANALYZER_RUN_MODE, {}); action = new QAction(tr("Clang Static Analyzer"), this); action->setToolTip(toolTip); menu->addAction(ActionManager::registerAction(action, "ClangStaticAnalyzer.Action"), |