summaryrefslogtreecommitdiff
path: root/src/plugins/bazaar/bazaarplugin.cpp
diff options
context:
space:
mode:
authorhjk <hjk121@nokiamail.com>2014-08-21 01:24:38 +0200
committerhjk <hjk121@nokiamail.com>2014-08-21 11:50:27 +0200
commit2481e71d1885561ff9af7091e88d9eb821dac008 (patch)
tree1d3f0c314e40dbcd9aa36ebcdc40a36c577f192b /src/plugins/bazaar/bazaarplugin.cpp
parent461a54bd2d8c4b6c3c342811d38c735fb7abb60a (diff)
downloadqt-creator-2481e71d1885561ff9af7091e88d9eb821dac008.tar.gz
Vcs: Move editor construction over to new scheme
Change-Id: I491b9f37bfe15ebc800fedd5c683bfaf24e63889 Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Diffstat (limited to 'src/plugins/bazaar/bazaarplugin.cpp')
-rw-r--r--src/plugins/bazaar/bazaarplugin.cpp11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/plugins/bazaar/bazaarplugin.cpp b/src/plugins/bazaar/bazaarplugin.cpp
index 7327c8ea2c..5a5f2fca68 100644
--- a/src/plugins/bazaar/bazaarplugin.cpp
+++ b/src/plugins/bazaar/bazaarplugin.cpp
@@ -166,8 +166,6 @@ bool BazaarPlugin::initialize(const QStringList &arguments, QString *errorMessag
Q_UNUSED(arguments);
Q_UNUSED(errorMessage);
- typedef VcsEditorFactory<BazaarEditor> BazaarEditorFactory;
-
m_client = new BazaarClient(&m_bazaarSettings);
initializeVcs(new BazaarControl(m_client));
@@ -179,8 +177,9 @@ bool BazaarPlugin::initialize(const QStringList &arguments, QString *errorMessag
static const char *describeSlot = SLOT(view(QString,QString));
const int editorCount = sizeof(editorParameters) / sizeof(VcsBaseEditorParameters);
+ const auto widgetCreator = []() { return new BazaarEditor; };
for (int i = 0; i < editorCount; i++)
- addAutoReleasedObject(new BazaarEditorFactory(editorParameters + i, m_client, describeSlot));
+ addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, m_client, describeSlot));
addAutoReleasedObject(new VcsSubmitEditorFactory<CommitEditor>(&submitEditorParameters));
@@ -657,7 +656,8 @@ void BazaarPlugin::testDiffFileResolving_data()
void BazaarPlugin::testDiffFileResolving()
{
- BazaarEditor editor(editorParameters + 2, 0);
+ BazaarEditor editor;
+ editor.setParameters(editorParameters + 2);
editor.testDiffFileResolving();
}
@@ -681,7 +681,8 @@ void BazaarPlugin::testLogResolving()
" (gz) Set approved revision and vote \"Approve\" when using lp-propose\n"
" --approve (Jonathan Lange)\n"
);
- BazaarEditor editor(editorParameters, 0);
+ BazaarEditor editor;
+ editor.setParameters(editorParameters);
editor.testLogResolving(data, "6572", "6571");
}
#endif