diff options
| author | hjk <hjk@qt.io> | 2018-10-22 17:56:04 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2018-10-23 14:12:39 +0000 |
| commit | 0f5d5dbfe48f7abb9ca83ffa3dfaa6ed88db58b3 (patch) | |
| tree | d48aa49fb61ccb74ae3479f0bf8326864d0f8c97 /src/plugins/autotoolsprojectmanager | |
| parent | 8471ce4331ec06e7dc6060014e0d6c35e34a78bc (diff) | |
| download | qt-creator-0f5d5dbfe48f7abb9ca83ffa3dfaa6ed88db58b3.tar.gz | |
ProjectExplorer: Make BuildStep::immutable use a data member
Default to false, remove all no-op reimplementations.
And rename the getter to isImmutable according to the rules.
Change-Id: I8cce79d88fb59badfa1cffcf30a46f7ff3b09e8b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/autotoolsprojectmanager')
6 files changed, 0 insertions, 18 deletions
diff --git a/src/plugins/autotoolsprojectmanager/autogenstep.cpp b/src/plugins/autotoolsprojectmanager/autogenstep.cpp index 640d524537..eb8affc2ad 100644 --- a/src/plugins/autotoolsprojectmanager/autogenstep.cpp +++ b/src/plugins/autotoolsprojectmanager/autogenstep.cpp @@ -138,8 +138,3 @@ BuildStepConfigWidget *AutogenStep::createConfigWidget() return widget; } - -bool AutogenStep::immutable() const -{ - return false; -} diff --git a/src/plugins/autotoolsprojectmanager/autogenstep.h b/src/plugins/autotoolsprojectmanager/autogenstep.h index 4f1d0b7f07..7e2a872e12 100644 --- a/src/plugins/autotoolsprojectmanager/autogenstep.h +++ b/src/plugins/autotoolsprojectmanager/autogenstep.h @@ -69,7 +69,6 @@ public: bool init(QList<const BuildStep *> &earlierSteps) override; void run(QFutureInterface<bool> &fi) override; ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override; - bool immutable() const override; private: ProjectExplorer::BaseStringAspect *m_additionalArgumentsAspect = nullptr; diff --git a/src/plugins/autotoolsprojectmanager/autoreconfstep.cpp b/src/plugins/autotoolsprojectmanager/autoreconfstep.cpp index 0f9d59e022..1eae293512 100644 --- a/src/plugins/autotoolsprojectmanager/autoreconfstep.cpp +++ b/src/plugins/autotoolsprojectmanager/autoreconfstep.cpp @@ -130,8 +130,3 @@ BuildStepConfigWidget *AutoreconfStep::createConfigWidget() return widget; } - -bool AutoreconfStep::immutable() const -{ - return false; -} diff --git a/src/plugins/autotoolsprojectmanager/autoreconfstep.h b/src/plugins/autotoolsprojectmanager/autoreconfstep.h index a4be8b5362..9d4ec34955 100644 --- a/src/plugins/autotoolsprojectmanager/autoreconfstep.h +++ b/src/plugins/autotoolsprojectmanager/autoreconfstep.h @@ -69,7 +69,6 @@ public: bool init(QList<const BuildStep *> &earlierSteps) override; void run(QFutureInterface<bool> &fi) override; ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override; - bool immutable() const override; private: ProjectExplorer::BaseStringAspect *m_additionalArgumentsAspect = nullptr; diff --git a/src/plugins/autotoolsprojectmanager/configurestep.cpp b/src/plugins/autotoolsprojectmanager/configurestep.cpp index f91c006790..50b7ca82e0 100644 --- a/src/plugins/autotoolsprojectmanager/configurestep.cpp +++ b/src/plugins/autotoolsprojectmanager/configurestep.cpp @@ -142,11 +142,6 @@ BuildStepConfigWidget *ConfigureStep::createConfigWidget() return m_widget.data(); } -bool ConfigureStep::immutable() const -{ - return false; -} - void ConfigureStep::notifyBuildDirectoryChanged() { updateDetails(); diff --git a/src/plugins/autotoolsprojectmanager/configurestep.h b/src/plugins/autotoolsprojectmanager/configurestep.h index 441075b989..59c6591b27 100644 --- a/src/plugins/autotoolsprojectmanager/configurestep.h +++ b/src/plugins/autotoolsprojectmanager/configurestep.h @@ -70,7 +70,6 @@ public: bool init(QList<const BuildStep *> &earlierSteps) override; void run(QFutureInterface<bool> &fi) override; ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override; - bool immutable() const override; void setAdditionalArguments(const QString &list); void notifyBuildDirectoryChanged(); |