diff options
| author | Daniel Teske <daniel.teske@nokia.com> | 2012-09-11 15:59:17 +0200 |
|---|---|---|
| committer | Daniel Teske <daniel.teske@nokia.com> | 2012-09-12 16:29:30 +0200 |
| commit | d3c0557444928b8a3b2812622b7d1137f81e05aa (patch) | |
| tree | 1ddbc010b55d969a11b2c30e6a2d32deb8e48b8e /src/plugins/autotoolsprojectmanager/makestep.cpp | |
| parent | f89352d7a87106ffbed9875c74fb3b61ff920029 (diff) | |
| download | qt-creator-d3c0557444928b8a3b2812622b7d1137f81e05aa.tar.gz | |
Make Toolchain::makeCommand return a full path to the make command
Requires passing in the environment to use. Also now the mingw toolchain
has a fall back to make.exe on windows. And the msvc toolchain falls
back to nmake even if the "use Jom" option is used.
Task-number: QTCREATORBUG-7831
Change-Id: I850a96da41a380eef8c6992e27a72fb63958c456
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Peter Kümmel <syntheticpp@gmx.net>
Diffstat (limited to 'src/plugins/autotoolsprojectmanager/makestep.cpp')
| -rw-r--r-- | src/plugins/autotoolsprojectmanager/makestep.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/plugins/autotoolsprojectmanager/makestep.cpp b/src/plugins/autotoolsprojectmanager/makestep.cpp index 15da9b6474..08c06f4cbc 100644 --- a/src/plugins/autotoolsprojectmanager/makestep.cpp +++ b/src/plugins/autotoolsprojectmanager/makestep.cpp @@ -189,7 +189,7 @@ bool MakeStep::init() pp->setMacroExpander(bc->macroExpander()); pp->setEnvironment(bc->environment()); pp->setWorkingDirectory(bc->buildDirectory()); - pp->setCommand(tc ? tc->makeCommand() : QLatin1String("make")); + pp->setCommand(tc ? tc->makeCommand(bc->environment()) : QLatin1String("make")); pp->setArguments(arguments); setOutputParser(new GnuMakeParser()); @@ -295,6 +295,7 @@ MakeStepConfigWidget::MakeStepConfigWidget(MakeStep *makeStep) : makeStep, SLOT(setAdditionalArguments(QString))); connect(makeStep, SIGNAL(additionalArgumentsChanged(QString)), this, SLOT(updateDetails())); + connect(m_makeStep->project(), SIGNAL(environmentChanged()), this, SLOT(updateDetails())); } QString MakeStepConfigWidget::displayName() const @@ -320,7 +321,7 @@ void MakeStepConfigWidget::updateDetails() param.setMacroExpander(bc->macroExpander()); param.setEnvironment(bc->environment()); param.setWorkingDirectory(bc->buildDirectory()); - param.setCommand(tc->makeCommand()); + param.setCommand(tc->makeCommand(bc->environment())); param.setArguments(arguments); m_summaryText = param.summary(displayName()); } else { |