diff options
author | Christian Kandeler <christian.kandeler@digia.com> | 2014-07-01 11:08:26 +0200 |
---|---|---|
committer | hjk <hjk121@nokiamail.com> | 2014-07-01 11:52:08 +0200 |
commit | 93304df0381cbeabf4c8435aec0ad55fbc7f8fe7 (patch) | |
tree | 7cbe348b1e3f88041b7e159aa335031e2c41bfc8 /src/plugins/autotoolsprojectmanager/makestep.cpp | |
parent | 139449239c7cd63ab933d13e20b37cd717a45fe7 (diff) | |
download | qt-creator-93304df0381cbeabf4c8435aec0ad55fbc7f8fe7.tar.gz |
Always pass Core::Id by value.
Currently we pass in some places by value, elsewhere by const ref and
for some weird reason also by const value in a lot of places. The latter
is particularly annoying, as it is also used in interfaces and therefore
forces all implementors to do the same, since leaving the "const" off is
causing compiler warnings with MSVC.
Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
Reviewed-by: hjk <hjk121@nokiamail.com>
Diffstat (limited to 'src/plugins/autotoolsprojectmanager/makestep.cpp')
-rw-r--r-- | src/plugins/autotoolsprojectmanager/makestep.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/plugins/autotoolsprojectmanager/makestep.cpp b/src/plugins/autotoolsprojectmanager/makestep.cpp index 04a5888664..40fee97b98 100644 --- a/src/plugins/autotoolsprojectmanager/makestep.cpp +++ b/src/plugins/autotoolsprojectmanager/makestep.cpp @@ -74,21 +74,21 @@ QList<Core::Id> MakeStepFactory::availableCreationIds(BuildStepList *parent) con return QList<Core::Id>(); } -QString MakeStepFactory::displayNameForId(const Core::Id id) const +QString MakeStepFactory::displayNameForId(Core::Id id) const { if (id == MAKE_STEP_ID) return tr("Make", "Display name for AutotoolsProjectManager::MakeStep id."); return QString(); } -bool MakeStepFactory::canCreate(BuildStepList *parent, const Core::Id id) const +bool MakeStepFactory::canCreate(BuildStepList *parent, Core::Id id) const { if (parent->target()->project()->id() == AUTOTOOLS_PROJECT_ID) return id == MAKE_STEP_ID; return false; } -BuildStep *MakeStepFactory::create(BuildStepList *parent, const Core::Id id) +BuildStep *MakeStepFactory::create(BuildStepList *parent, Core::Id id) { if (!canCreate(parent, id)) return 0; @@ -133,7 +133,7 @@ MakeStep::MakeStep(BuildStepList* bsl) : ctor(); } -MakeStep::MakeStep(BuildStepList *bsl, const Core::Id id) : +MakeStep::MakeStep(BuildStepList *bsl, Core::Id id) : AbstractProcessStep(bsl, id), m_clean(false) { |