diff options
| author | hjk <qthjk@ovi.com> | 2012-08-03 15:24:33 +0200 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@nokia.com> | 2012-08-06 10:37:43 +0200 |
| commit | 83e573f2ece5902454b19aab8ecac4f4ca4b91e5 (patch) | |
| tree | da1520aa62a5eb87d9c9e770a5ef974d77be3a7b /src/plugins/autotoolsprojectmanager/makestep.cpp | |
| parent | 7ca93f9b1e728b99a0a4d554733a1fa31e6ab4d9 (diff) | |
| download | qt-creator-83e573f2ece5902454b19aab8ecac4f4ca4b91e5.tar.gz | |
use new id comparison operators to reduce line noise and save cycles
Change-Id: I2e7d81a4efb75877901d29964df4f71314e951b4
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Diffstat (limited to 'src/plugins/autotoolsprojectmanager/makestep.cpp')
| -rw-r--r-- | src/plugins/autotoolsprojectmanager/makestep.cpp | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/src/plugins/autotoolsprojectmanager/makestep.cpp b/src/plugins/autotoolsprojectmanager/makestep.cpp index a03d696104..2ca4ae8102 100644 --- a/src/plugins/autotoolsprojectmanager/makestep.cpp +++ b/src/plugins/autotoolsprojectmanager/makestep.cpp @@ -70,24 +70,23 @@ MakeStepFactory::MakeStepFactory(QObject *parent) : QList<Core::Id> MakeStepFactory::availableCreationIds(BuildStepList *parent) const { - if (parent->target()->project()->id() == Core::Id(AUTOTOOLS_PROJECT_ID)) + if (parent->target()->project()->id() == AUTOTOOLS_PROJECT_ID) return QList<Core::Id>() << Core::Id(MAKE_STEP_ID); return QList<Core::Id>(); } QString MakeStepFactory::displayNameForId(const Core::Id id) const { - if (id == Core::Id(MAKE_STEP_ID)) + if (id == MAKE_STEP_ID) return tr("Make", "Display name for AutotoolsProjectManager::MakeStep id."); return QString(); } bool MakeStepFactory::canCreate(BuildStepList *parent, const Core::Id id) const { - if (parent->target()->project()->id() != Core::Id(AUTOTOOLS_PROJECT_ID)) - return false; - - return Core::Id(MAKE_STEP_ID) == id; + if (parent->target()->project()->id() == AUTOTOOLS_PROJECT_ID) + return id == MAKE_STEP_ID; + return false; } BuildStep *MakeStepFactory::create(BuildStepList *parent, const Core::Id id) |