diff options
| author | hjk <hjk@theqtcompany.com> | 2016-05-18 12:37:29 +0200 |
|---|---|---|
| committer | hjk <hjk@theqtcompany.com> | 2016-06-10 10:34:51 +0000 |
| commit | 519cc8ded616758cb85857e8845fdc5847339e3a (patch) | |
| tree | 04069d8c648a7169008e1a35c057349b358e2f2f /src/plugins/autotoolsprojectmanager/configurestep.h | |
| parent | 4ce0494284dfc3bf832e54f9315b9bf6d02a4d28 (diff) | |
| download | qt-creator-519cc8ded616758cb85857e8845fdc5847339e3a.tar.gz | |
ProjectExplorer: De-duplicate code in IBuildStepFactory derived classes
This removes 900 lines of duplicated code, some duplicated checks at
runtime and some (minor) quadratic behavior when gathering display names.
canClone(), canRestore() and canCreate() and restore() use the same
pattern. Handle that on the core side once. Leave retore() virtual to let
the ios code unmodified (which is likely not needed, later...). Introduce
'Unclonable' and 'Uncreatable' flags to keep Android package installation
and WinRT deployment (non-)functionality unchanged.
Change-Id: I0325479aff818a4038b2f241ca733b8d8cd66f2f
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Diffstat (limited to 'src/plugins/autotoolsprojectmanager/configurestep.h')
| -rw-r--r-- | src/plugins/autotoolsprojectmanager/configurestep.h | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/src/plugins/autotoolsprojectmanager/configurestep.h b/src/plugins/autotoolsprojectmanager/configurestep.h index 77d34a8fd0..a809e0a63e 100644 --- a/src/plugins/autotoolsprojectmanager/configurestep.h +++ b/src/plugins/autotoolsprojectmanager/configurestep.h @@ -54,17 +54,11 @@ class ConfigureStepFactory : public ProjectExplorer::IBuildStepFactory public: ConfigureStepFactory(QObject *parent = 0); - QList<Core::Id> availableCreationIds(ProjectExplorer::BuildStepList *bc) const override; - QString displayNameForId(Core::Id id) const override; + QList<ProjectExplorer::BuildStepInfo> + availableSteps(ProjectExplorer::BuildStepList *parent) const override; - bool canCreate(ProjectExplorer::BuildStepList *parent, Core::Id id) const override; ProjectExplorer::BuildStep *create(ProjectExplorer::BuildStepList *parent, Core::Id id) override; - bool canClone(ProjectExplorer::BuildStepList *parent, ProjectExplorer::BuildStep *source) const override; ProjectExplorer::BuildStep *clone(ProjectExplorer::BuildStepList *parent, ProjectExplorer::BuildStep *source) override; - bool canRestore(ProjectExplorer::BuildStepList *parent, const QVariantMap &map) const override; - ProjectExplorer::BuildStep *restore(ProjectExplorer::BuildStepList *parent, const QVariantMap &map) override; - - bool canHandle(ProjectExplorer::BuildStepList *parent) const; }; ////////////////////////// |