diff options
| author | Konstantin Tokarev <annulen@yandex.ru> | 2012-05-12 11:53:56 +0400 |
|---|---|---|
| committer | Daniel Teske <daniel.teske@nokia.com> | 2012-05-14 11:03:14 +0200 |
| commit | 0741c7de6dd9b8b9d531ea9accc554e88c55526e (patch) | |
| tree | ea4188e7573fc02affca690e1ed03b99d86cf3b4 /src/plugins/analyzerbase/analyzerruncontrol.cpp | |
| parent | 34206b0385f95a3c041ab23c1b0e281aec45ea9e (diff) | |
| download | qt-creator-0741c7de6dd9b8b9d531ea9accc554e88c55526e.tar.gz | |
Renamed TaskHub::popup to requestPopup and removed boolean flag.
* TaskHub does not pop up itself because it is not a widget.
* popup(true) is never used and may lead to bad user experience.
* use boolean flag goes agains Qt API design guidelines.
Change-Id: Idf28a8d4af66022961d94f1d1cdeeaf155b67c52
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Diffstat (limited to 'src/plugins/analyzerbase/analyzerruncontrol.cpp')
| -rw-r--r-- | src/plugins/analyzerbase/analyzerruncontrol.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/analyzerbase/analyzerruncontrol.cpp b/src/plugins/analyzerbase/analyzerruncontrol.cpp index 5cb91674a5..49ea6a14a3 100644 --- a/src/plugins/analyzerbase/analyzerruncontrol.cpp +++ b/src/plugins/analyzerbase/analyzerruncontrol.cpp @@ -179,7 +179,7 @@ void AnalyzerRunControl::addTask(Task::TaskType type, const QString &description TaskHub *hub = ProjectExplorerPlugin::instance()->taskHub(); hub->addTask(Task(type, description, Utils::FileName::fromUserInput(file), line, Core::Id(Constants::ANALYZERTASK_ID))); - hub->popup(false); + hub->requestPopup(); } } // namespace Analyzer |