diff options
| author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2013-05-17 08:20:15 +0300 |
|---|---|---|
| committer | Orgad Shaneh <orgads@gmail.com> | 2013-05-17 15:13:24 +0200 |
| commit | 05b3903b6a6a8d919ffe71473a3c3a2dce446e7d (patch) | |
| tree | dacc603780eaa2d20cb9d0e9a71167096c43775f /src/libs/utils/environment.cpp | |
| parent | fc6ec40f2f85f49e450f28e01e8fdc27b729258d (diff) | |
| download | qt-creator-05b3903b6a6a8d919ffe71473a3c3a2dce446e7d.tar.gz | |
Environment: Move isEmpty() test to beginning
No reason to initialize a QFileInfo for an empty string
Change-Id: I537fc98e1a5dd2283db9e5e60717eb8873c02b13
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Diffstat (limited to 'src/libs/utils/environment.cpp')
| -rw-r--r-- | src/libs/utils/environment.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/libs/utils/environment.cpp b/src/libs/utils/environment.cpp index 3568363eec..e0d03a9ab6 100644 --- a/src/libs/utils/environment.cpp +++ b/src/libs/utils/environment.cpp @@ -236,12 +236,12 @@ QString Environment::searchInDirectory(const QStringList &execs, QString directo QString Environment::searchInPath(const QString &executable, const QStringList &additionalDirs) const { - QString exec = QDir::cleanPath(expandVariables(executable)); - QFileInfo fi(exec); - if (executable.isEmpty()) return QString(); + QString exec = QDir::cleanPath(expandVariables(executable)); + QFileInfo fi(exec); + QStringList execs(exec); if (HostOsInfo::isWindowsHost()) { // Check all the executable extensions on windows: |