diff options
author | Roberto Raggi <roberto.raggi@nokia.com> | 2009-12-01 11:33:13 +0100 |
---|---|---|
committer | Roberto Raggi <roberto.raggi@nokia.com> | 2009-12-01 11:46:36 +0100 |
commit | fade61a8a9397f44d31c5ab4ede57e5259de8880 (patch) | |
tree | 539129b8b2594cad57752f3883b4c766f1299ef6 /src/libs/cplusplus/CheckUndefinedSymbols.cpp | |
parent | b792b934e48c741b804f19378b6028f32c1c04eb (diff) | |
download | qt-creator-fade61a8a9397f44d31c5ab4ede57e5259de8880.tar.gz |
Use const literals.
Diffstat (limited to 'src/libs/cplusplus/CheckUndefinedSymbols.cpp')
-rw-r--r-- | src/libs/cplusplus/CheckUndefinedSymbols.cpp | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/src/libs/cplusplus/CheckUndefinedSymbols.cpp b/src/libs/cplusplus/CheckUndefinedSymbols.cpp index 51d02a0dc4..f3d27df502 100644 --- a/src/libs/cplusplus/CheckUndefinedSymbols.cpp +++ b/src/libs/cplusplus/CheckUndefinedSymbols.cpp @@ -65,7 +65,7 @@ void CheckUndefinedSymbols::operator()(AST *ast) QByteArray CheckUndefinedSymbols::templateParameterName(NameAST *ast) const { if (ast && ast->name) { - if (Identifier *id = ast->name->identifier()) + if (const Identifier *id = ast->name->identifier()) return QByteArray::fromRawData(id->chars(), id->size()); } @@ -92,7 +92,7 @@ bool CheckUndefinedSymbols::isType(const QByteArray &name) const Symbol *member = members->symbolAt(m); if (member->isTypedef() && member->isDeclaration()) { - if (Identifier *id = member->identifier()) { + if (const Identifier *id = member->identifier()) { if (name == id->chars()) return true; } @@ -114,7 +114,7 @@ bool CheckUndefinedSymbols::isType(const QByteArray &name) const return _types.contains(name); } -bool CheckUndefinedSymbols::isType(Identifier *id) const +bool CheckUndefinedSymbols::isType(const Identifier *id) const { if (! id) return false; @@ -127,7 +127,7 @@ void CheckUndefinedSymbols::addType(Name *name) if (! name) return; - if (Identifier *id = name->identifier()) + if (const Identifier *id = name->identifier()) _types.insert(QByteArray(id->chars(), id->size())); } @@ -136,7 +136,7 @@ void CheckUndefinedSymbols::addProtocol(Name *name) if (!name) return; - if (Identifier *id = name->identifier()) + if (const Identifier *id = name->identifier()) _protocols.insert(QByteArray(id->chars(), id->size())); } @@ -176,7 +176,7 @@ void CheckUndefinedSymbols::buildTypeMap(NamespaceBinding *binding, QSet<Namespa if (! processed->contains(binding)) { processed->insert(binding); - if (Identifier *id = binding->identifier()) { + if (const Identifier *id = binding->identifier()) { _namespaceNames.insert(QByteArray(id->chars(), id->size())); } @@ -256,7 +256,7 @@ bool CheckUndefinedSymbols::visit(NamedTypeSpecifierAST *ast) unsigned line, col; getTokenStartPosition(ast->firstToken(), &line, &col); // qWarning() << _doc->fileName() << line << col; - } else if (Identifier *id = ast->name->name->identifier()) { + } else if (const Identifier *id = ast->name->name->identifier()) { if (! isType(id)) { if (FunctionDeclaratorAST *functionDeclarator = currentFunctionDeclarator()) { if (functionDeclarator->as_cpp_initializer) @@ -368,7 +368,7 @@ bool CheckUndefinedSymbols::visit(BaseSpecifierAST *base) bool resolvedBaseClassName = false; if (Name *name = nameAST->name) { - Identifier *id = name->identifier(); + const Identifier *id = name->identifier(); const QByteArray spell = QByteArray::fromRawData(id->chars(), id->size()); if (isType(spell)) resolvedBaseClassName = true; @@ -406,7 +406,7 @@ bool CheckUndefinedSymbols::visit(QualifiedNameAST *ast) QualifiedNameId *q = ast->name->asQualifiedNameId(); for (unsigned i = 0; i < q->nameCount() - 1; ++i) { Name *name = q->nameAt(i); - if (Identifier *id = name->identifier()) { + if (const Identifier *id = name->identifier()) { const QByteArray spell = QByteArray::fromRawData(id->chars(), id->size()); if (! (_namespaceNames.contains(spell) || isType(id))) { translationUnit()->warning(ast->firstToken(), @@ -475,7 +475,7 @@ bool CheckUndefinedSymbols::visit(ObjCClassDeclarationAST *ast) bool resolvedSuperClassName = false; if (Name *name = nameAST->name) { - Identifier *id = name->identifier(); + const Identifier *id = name->identifier(); const QByteArray spell = QByteArray::fromRawData(id->chars(), id->size()); if (isType(spell)) resolvedSuperClassName = true; @@ -497,7 +497,7 @@ bool CheckUndefinedSymbols::visit(ObjCProtocolRefsAST *ast) bool resolvedProtocolName = false; if (Name *name = nameAST->name) { - Identifier *id = name->identifier(); + const Identifier *id = name->identifier(); const QByteArray spell = QByteArray::fromRawData(id->chars(), id->size()); if (isProtocol(spell)) resolvedProtocolName = true; @@ -522,11 +522,11 @@ bool CheckUndefinedSymbols::visit(ObjCProtocolRefsAST *ast) bool CheckUndefinedSymbols::visit(ObjCPropertyDeclarationAST *ast) { for (List<ObjCPropertyDeclaration *> *iter = ast->symbols; iter; iter = iter->next) { - if (Name *getterName = iter->value->getterName()) { + if (/*Name *getterName = */ iter->value->getterName()) { // FIXME: resolve the symbol for the name, and check its signature. } - if (Name *setterName = iter->value->setterName()) { + if (/*Name *setterName = */ iter->value->setterName()) { // FIXME: resolve the symbol for the name, and check its signature. } } |