summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobias Hunger <tobias.hunger@qt.io>2017-06-02 09:11:39 +0200
committerTobias Hunger <tobias.hunger@qt.io>2017-06-13 12:47:44 +0000
commit460e1d7e939ae0e19a17ab26cfb6328aff706519 (patch)
tree1d13ffce441b287f3daf0c8670515eb4f4b362d0
parent9f83808dc0793f25a6f74d6b144dd2f12c53fe3b (diff)
downloadqt-creator-460e1d7e939ae0e19a17ab26cfb6328aff706519.tar.gz
CMake: Add "test" target to cmake builds
Always show a test target for cmake projects. This will show even if there are no tests in the project. But I think it is more annoying *not* to be able to run tests via the locator when tests are available than getting an error message when attempting that with a project that does not have tests. Task-number: QTCREATORBUG-18323 Change-Id: Iba85aa868cb9bfe6c3f44a7ffff620d081d3082f Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
-rw-r--r--src/plugins/cmakeprojectmanager/builddirmanager.cpp2
-rw-r--r--src/plugins/cmakeprojectmanager/cmakebuildstep.cpp7
-rw-r--r--src/plugins/cmakeprojectmanager/cmakebuildstep.h1
3 files changed, 9 insertions, 1 deletions
diff --git a/src/plugins/cmakeprojectmanager/builddirmanager.cpp b/src/plugins/cmakeprojectmanager/builddirmanager.cpp
index dbfc4825eb..ca2fd4bd6a 100644
--- a/src/plugins/cmakeprojectmanager/builddirmanager.cpp
+++ b/src/plugins/cmakeprojectmanager/builddirmanager.cpp
@@ -334,6 +334,8 @@ QList<CMakeBuildTarget> BuildDirManager::buildTargets() const
m_buildTargets.append(utilityTarget(CMakeBuildStep::allTarget(), this));
m_buildTargets.append(utilityTarget(CMakeBuildStep::cleanTarget(), this));
m_buildTargets.append(utilityTarget(CMakeBuildStep::installTarget(), this));
+ m_buildTargets.append(utilityTarget(CMakeBuildStep::testTarget(), this));
+
m_buildTargets.append(m_reader->buildTargets());
}
return m_buildTargets;
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
index 1ecb3e4bc8..d87a538f98 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
@@ -404,9 +404,14 @@ QString CMakeBuildStep::installTarget()
return QString("install");
}
+QString CMakeBuildStep::testTarget()
+{
+ return QString("test");
+}
+
QStringList CMakeBuildStep::specialTargets()
{
- return { allTarget(), cleanTarget(), installTarget() };
+ return { allTarget(), cleanTarget(), installTarget(), testTarget() };
}
//
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildstep.h b/src/plugins/cmakeprojectmanager/cmakebuildstep.h
index e740baeaa7..70d89c8783 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildstep.h
+++ b/src/plugins/cmakeprojectmanager/cmakebuildstep.h
@@ -80,6 +80,7 @@ public:
static QString cleanTarget();
static QString allTarget();
static QString installTarget();
+ static QString testTarget();
static QStringList specialTargets();
signals: