summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Schulz <david.schulz@qt.io>2016-11-25 13:00:03 +0100
committerDavid Schulz <david.schulz@qt.io>2016-11-25 12:04:52 +0000
commitcc765e9fada9ef304492250dcc262ba45cb49a1e (patch)
tree3b07f472b424caee64ff1cfb26ace0492ed51a0f
parenteefe4fb7f7ca7d34cc0481d6f954f087238608eb (diff)
downloadqt-creator-cc765e9fada9ef304492250dcc262ba45cb49a1e.tar.gz
Debugger: Raise exception for invalid memory
The api doesn't expect empty arrays and doesn't validate indices before accessing them. Change-Id: I6d6fde9eec6d65d5db351be821fed892a77fabc1 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
-rw-r--r--share/qtcreator/debugger/cdbbridge.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/share/qtcreator/debugger/cdbbridge.py b/share/qtcreator/debugger/cdbbridge.py
index cc271318d1..0f0b96cd0f 100644
--- a/share/qtcreator/debugger/cdbbridge.py
+++ b/share/qtcreator/debugger/cdbbridge.py
@@ -241,7 +241,10 @@ class Dumper(DumperBase):
self.report('result={%s}' % (result))
def readRawMemory(self, address, size):
- return cdbext.readRawMemory(address, size)
+ mem = cdbext.readRawMemory(address, size)
+ if len(mem) != size:
+ raise Exception("Invalid memory request")
+ return mem
def findStaticMetaObject(self, typeName):
ptr = self.findValueByExpression('&' + typeName + '::staticMetaObject')