summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlessandro Portale <alessandro.portale@qt.io>2020-02-08 00:20:53 +0100
committerAlessandro Portale <alessandro.portale@qt.io>2020-02-10 07:56:18 +0000
commit8228d43579c41ae78dabdf03c0422601661b75fa (patch)
tree158f4d469b308a5b41a49714f873a5dbc9e8e79d
parentce40e13e3ac1277d0050a969c11950be4db06c21 (diff)
downloadqt-creator-8228d43579c41ae78dabdf03c0422601661b75fa.tar.gz
Core: Turn the IDE revision link in VersionDialog to be Opt-in
If IDE_REVISION is set, don't default to some hardcoded string for IDE_REVISION_IDE_STR. Task-number: QTCREATORBUG-23524 Change-Id: Icc6aa6a4a0fb24178c5c1bd5feaa96b6a5b07115 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
-rw-r--r--cmake/QtCreatorIDEBranding.cmake3
-rw-r--r--src/app/app_version.h.in2
2 files changed, 1 insertions, 4 deletions
diff --git a/cmake/QtCreatorIDEBranding.cmake b/cmake/QtCreatorIDEBranding.cmake
index b8c8f560b8..bed77a9e79 100644
--- a/cmake/QtCreatorIDEBranding.cmake
+++ b/cmake/QtCreatorIDEBranding.cmake
@@ -12,6 +12,3 @@ set(IDE_DISPLAY_NAME "Qt Creator") # The IDE display name.
set(IDE_ID "qtcreator") # The IDE id (no spaces, lowercase!)
set(IDE_CASED_ID "QtCreator") # The cased IDE id (no spaces!)
set(IDE_BUNDLE_IDENTIFIER "org.qt-project.${IDE_ID}") # The macOS application bundle identifier.
-
-set(IDE_REVISION_URL_STR "https://code.qt.io/cgit/qt-creator/qt-creator.git/log/?id=%1")
- # The revision url in the version dialog
diff --git a/src/app/app_version.h.in b/src/app/app_version.h.in
index e7cf02cd03..a3fc7f4b4e 100644
--- a/src/app/app_version.h.in
+++ b/src/app/app_version.h.in
@@ -57,7 +57,7 @@ const char IDE_REVISION_STR[] = \"\";
#ifdef IDE_REVISION_URL
const char IDE_REVISION_URL_STR[] = STRINGIFY(IDE_REVISION_URL);
#else
-const char IDE_REVISION_URL_STR[] = \"https://code.qt.io/cgit/qt-creator/qt-creator.git/log/?id=%1\";
+const char IDE_REVISION_URL_STR[] = \"\";
#endif
// changes the path where the settings are saved to