summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlessandro Portale <alessandro.portale@qt.io>2019-11-19 17:27:32 +0100
committerAlessandro Portale <alessandro.portale@qt.io>2019-11-22 11:05:53 +0000
commit2a7a90823362602ad0badc261773ff08c237ab2d (patch)
treefabd49db2d284c4875d70edb7a1d607b470cc860
parent0b510f173eccc5ca07b2c9fbb587107cc6aacb3f (diff)
downloadqt-creator-2a7a90823362602ad0badc261773ff08c237ab2d.tar.gz
McuSupport: Only (re-)generate kits when on Mcu options page
... less surprises, like for example user is on the Kits page, edits an existing kit, and that gets overwritten when pressing "Apply" Change-Id: I2d936b757cb5c891a087854805fa2f056834185f Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
-rw-r--r--src/plugins/mcusupport/mcusupportoptionspage.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/plugins/mcusupport/mcusupportoptionspage.cpp b/src/plugins/mcusupport/mcusupportoptionspage.cpp
index 06bb9a86e6..c0d1c42afc 100644
--- a/src/plugins/mcusupport/mcusupportoptionspage.cpp
+++ b/src/plugins/mcusupport/mcusupportoptionspage.cpp
@@ -168,6 +168,9 @@ void McuSupportOptionsPage::apply()
QTC_ASSERT(m_options->armGccPackage, return);
QTC_ASSERT(m_options->qtForMCUsSdkPackage, return);
+ if (!widget()->isVisible())
+ return; // Only create/overwrite kits when this option page is shown
+
const McuTarget *mcuTarget = m_widget->currentMcuTarget();
if (!mcuTarget)
return;