summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEike Ziller <eike.ziller@digia.com>2014-08-15 10:49:59 +0200
committerEike Ziller <eike.ziller@digia.com>2014-08-15 15:33:14 +0200
commit264df002e62d1c0a3243f7f4bd2b29fa047e60da (patch)
treeee022292b280a2cfef41ec03802257056e854039
parent23536e9b426aba67880a9ef19e9c67517e642df0 (diff)
downloadqt-creator-264df002e62d1c0a3243f7f4bd2b29fa047e60da.tar.gz
VCS: Make submit editor closing independent from current editor
The VCS plugins keep a reference to the submit editor, so it can explicitly be closed, instead of relying on the correct currentEditor in the editor manager. Change-Id: I14aab63447f790f2065a8d8dc6b50aeacbd1e941 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
-rw-r--r--src/plugins/bazaar/bazaarplugin.cpp2
-rw-r--r--src/plugins/clearcase/clearcaseplugin.cpp2
-rw-r--r--src/plugins/cvs/cvsplugin.cpp2
-rw-r--r--src/plugins/git/gitplugin.cpp2
-rw-r--r--src/plugins/mercurial/mercurialplugin.cpp2
-rw-r--r--src/plugins/perforce/perforceplugin.cpp2
-rw-r--r--src/plugins/subversion/subversionplugin.cpp2
7 files changed, 7 insertions, 7 deletions
diff --git a/src/plugins/bazaar/bazaarplugin.cpp b/src/plugins/bazaar/bazaarplugin.cpp
index 0cad2b85e9..7368638409 100644
--- a/src/plugins/bazaar/bazaarplugin.cpp
+++ b/src/plugins/bazaar/bazaarplugin.cpp
@@ -681,7 +681,7 @@ void BazaarPlugin::commitFromEditor()
{
// Close the submit editor
m_submitActionTriggered = true;
- EditorManager::closeEditor();
+ EditorManager::closeEditor(submitEditor());
}
void BazaarPlugin::uncommit()
diff --git a/src/plugins/clearcase/clearcaseplugin.cpp b/src/plugins/clearcase/clearcaseplugin.cpp
index 3fab90897d..496c53f964 100644
--- a/src/plugins/clearcase/clearcaseplugin.cpp
+++ b/src/plugins/clearcase/clearcaseplugin.cpp
@@ -1475,7 +1475,7 @@ void ClearCasePlugin::describe(const QString &source, const QString &changeNr)
void ClearCasePlugin::checkInSelected()
{
m_submitActionTriggered = true;
- EditorManager::closeEditor();
+ EditorManager::closeEditor(submitEditor());
}
QString ClearCasePlugin::runCleartoolSync(const QString &workingDir,
diff --git a/src/plugins/cvs/cvsplugin.cpp b/src/plugins/cvs/cvsplugin.cpp
index 2efc277ea0..69948e3365 100644
--- a/src/plugins/cvs/cvsplugin.cpp
+++ b/src/plugins/cvs/cvsplugin.cpp
@@ -1122,7 +1122,7 @@ bool CvsPlugin::describe(const QString &repositoryPath,
void CvsPlugin::submitCurrentLog()
{
m_submitActionTriggered = true;
- EditorManager::closeEditor(EditorManager::currentEditor());
+ EditorManager::closeEditor(submitEditor());
}
// Run CVS. At this point, file arguments must be relative to
diff --git a/src/plugins/git/gitplugin.cpp b/src/plugins/git/gitplugin.cpp
index 86eca7b04a..33d41f952d 100644
--- a/src/plugins/git/gitplugin.cpp
+++ b/src/plugins/git/gitplugin.cpp
@@ -1014,7 +1014,7 @@ void GitPlugin::submitCurrentLog()
{
// Close the submit editor
m_submitActionTriggered = true;
- EditorManager::closeEditor();
+ EditorManager::closeEditor(submitEditor());
}
bool GitPlugin::submitEditorAboutToClose()
diff --git a/src/plugins/mercurial/mercurialplugin.cpp b/src/plugins/mercurial/mercurialplugin.cpp
index b962744d98..8789987cf4 100644
--- a/src/plugins/mercurial/mercurialplugin.cpp
+++ b/src/plugins/mercurial/mercurialplugin.cpp
@@ -596,7 +596,7 @@ void MercurialPlugin::commitFromEditor()
{
// Close the submit editor
m_submitActionTriggered = true;
- Core::EditorManager::closeEditor();
+ Core::EditorManager::closeEditor(submitEditor());
}
bool MercurialPlugin::submitEditorAboutToClose()
diff --git a/src/plugins/perforce/perforceplugin.cpp b/src/plugins/perforce/perforceplugin.cpp
index eee131f369..498c168824 100644
--- a/src/plugins/perforce/perforceplugin.cpp
+++ b/src/plugins/perforce/perforceplugin.cpp
@@ -1329,7 +1329,7 @@ void PerforcePlugin::describe(const QString & source, const QString &n)
void PerforcePlugin::submitCurrentLog()
{
m_submitActionTriggered = true;
- EditorManager::closeEditor(EditorManager::currentEditor());
+ EditorManager::closeEditor(submitEditor());
}
void PerforcePlugin::cleanCommitMessageFile()
diff --git a/src/plugins/subversion/subversionplugin.cpp b/src/plugins/subversion/subversionplugin.cpp
index 12a68f84d0..6affa58cfd 100644
--- a/src/plugins/subversion/subversionplugin.cpp
+++ b/src/plugins/subversion/subversionplugin.cpp
@@ -981,7 +981,7 @@ void SubversionPlugin::slotDescribe()
void SubversionPlugin::submitCurrentLog()
{
m_submitActionTriggered = true;
- EditorManager::closeEditor(EditorManager::currentEditor());
+ EditorManager::closeEditor(submitEditor());
}
SubversionResponse