diff options
| author | Nikolai Kosjar <nikolai.kosjar@theqtcompany.com> | 2015-07-29 12:28:19 +0200 |
|---|---|---|
| committer | Nikolai Kosjar <nikolai.kosjar@theqtcompany.com> | 2015-07-29 12:18:03 +0000 |
| commit | 5145fc8509111c22185cbbed3d997429c5da1433 (patch) | |
| tree | 37e87c4f1b53d95df2f1336247aadd9ee02dadd9 | |
| parent | f4796d00327a6a7a781b52599da57a3e1aa98c55 (diff) | |
| download | qt-creator-5145fc8509111c22185cbbed3d997429c5da1433.tar.gz | |
TextEditor: Fix potential memory leak in code assist
Manually managing the ownership of the code assist objets gets messy. We
should use smart pointers.
Change-Id: I29fe665e52438a79c3268b74898c583bb302f1fc
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
| -rw-r--r-- | src/plugins/texteditor/codeassist/codeassistant.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/plugins/texteditor/codeassist/codeassistant.cpp b/src/plugins/texteditor/codeassist/codeassistant.cpp index e7a4d181ae..19c117565d 100644 --- a/src/plugins/texteditor/codeassist/codeassistant.cpp +++ b/src/plugins/texteditor/codeassist/codeassistant.cpp @@ -229,8 +229,10 @@ void CodeAssistantPrivate::requestProposal(AssistReason reason, m_assistKind = kind; IAssistProcessor *processor = provider->createProcessor(); AssistInterface *assistInterface = m_editorWidget->createAssistInterface(kind, reason); - if (!assistInterface) + if (!assistInterface) { + delete processor; return; + } switch (provider->runType()) { case IAssistProvider::Synchronous: { |