summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Hartmann <thomas.hartmann@qt.io>2022-08-24 19:56:21 +0200
committerTim Jenssen <tim.jenssen@qt.io>2022-08-24 19:31:21 +0000
commit1bfd078071f6a26d00a789c66ecd0aa77ef3d00b (patch)
tree5a2b6ee05767f5fd78512071680707a4296702ea
parentae872359d00d746eaaa307c4d249ea271463f543 (diff)
downloadqt-creator-1bfd078071f6a26d00a789c66ecd0aa77ef3d00b.tar.gz
QmlDesigner: Fix crash
Tracking the target with a QPointer in case the target gets deleted. Change-Id: I9cca4a5017b7fc77941fd46653847a00363c060e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
-rw-r--r--src/plugins/qmldesigner/designercore/include/nodeinstanceview.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/plugins/qmldesigner/designercore/include/nodeinstanceview.h b/src/plugins/qmldesigner/designercore/include/nodeinstanceview.h
index d6e3074666..6209ff19d0 100644
--- a/src/plugins/qmldesigner/designercore/include/nodeinstanceview.h
+++ b/src/plugins/qmldesigner/designercore/include/nodeinstanceview.h
@@ -39,6 +39,7 @@
#include <QElapsedTimer>
#include <QHash>
#include <QImage>
+#include <QPointer>
#include <QRectF>
#include <QTime>
#include <QTimer>
@@ -277,7 +278,7 @@ private:
std::unique_ptr<NodeInstanceServerProxy> m_nodeInstanceServer;
QImage m_baseStatePreviewImage;
QElapsedTimer m_lastCrashTime;
- ProjectExplorer::Target *m_currentTarget = nullptr;
+ QPointer<ProjectExplorer::Target> m_currentTarget;
int m_restartProcessTimerId;
RewriterTransaction m_puppetTransaction;