diff options
| author | Thomas Hartmann <thomas.hartmann@qt.io> | 2022-03-22 10:04:04 +0100 |
|---|---|---|
| committer | Thomas Hartmann <thomas.hartmann@qt.io> | 2022-03-22 11:50:23 +0000 |
| commit | 70c44acdd88efdff3e51eede3f2ce00faf26a028 (patch) | |
| tree | 080cf83e8eccf18bfb22c8c2557caa1c2af5f6da | |
| parent | 2846bef563294226d71634167dfaa9271cf1c460 (diff) | |
| download | qt-creator-70c44acdd88efdff3e51eede3f2ce00faf26a028.tar.gz | |
QmlDesigner: Fix itemlibrary template generation
Since this is likely executed in a transaction and
newQmlObjectNode.setId() uses refactoring on the QML code
this is not working as expected. Setting the id without any refactoring,
that triggers changes of the QML code, is save to be used.
Change-Id: I5d29689eff34827de9e451f433d9a4b42569a64e
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
| -rw-r--r-- | src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp b/src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp index d6f417407c..f8044fd6da 100644 --- a/src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp +++ b/src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp @@ -335,7 +335,7 @@ QmlObjectNode QmlVisualNode::createQmlObjectNode(AbstractView *view, if (!newQmlObjectNode.isValid()) return; - newQmlObjectNode.setId(view->model()->generateNewId(itemLibraryEntry.name())); + newQmlObjectNode.modelNode().setIdWithoutRefactoring(view->model()->generateNewId(itemLibraryEntry.name())); for (const auto &propertyBindingEntry : propertyBindingList) newQmlObjectNode.modelNode().bindingProperty(propertyBindingEntry.first).setExpression(propertyBindingEntry.second); |