summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobias Hunger <tobias.hunger@qt.io>2019-10-11 13:15:11 +0200
committerTobias Hunger <tobias.hunger@qt.io>2019-10-21 11:20:14 +0000
commitb128d498b2da55a9f87cd2eabb802acc0c48e7d4 (patch)
tree384fb57d355fc58dfce14babed25cf7e8c020cf0
parentfab360d83d4c9e0ca77ecfb44fccc974f279399c (diff)
downloadqt-creator-b128d498b2da55a9f87cd2eabb802acc0c48e7d4.tar.gz
CMake Buildsystem: Enable visibility settings for binaries
This should not matter, but makes the add_qtc_executable targets match up with the PCH, so that they should build a bit faster. Change-Id: Ibecaaf7fd98d5b927d52e4956b1bea4a5775afba Reviewed-by: Cristian Adam <cristian.adam@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
-rw-r--r--cmake/QtCreatorAPI.cmake2
-rw-r--r--src/shared/qtcreator_gui_pch.h13
-rw-r--r--src/shared/qtcreator_pch.h13
3 files changed, 5 insertions, 23 deletions
diff --git a/cmake/QtCreatorAPI.cmake b/cmake/QtCreatorAPI.cmake
index f122ef1daf..300b7cd50a 100644
--- a/cmake/QtCreatorAPI.cmake
+++ b/cmake/QtCreatorAPI.cmake
@@ -838,6 +838,8 @@ function(add_qtc_executable name)
INSTALL_RPATH "${_RPATH_BASE}/${_RELATIVE_LIB_PATH}"
RUNTIME_OUTPUT_DIRECTORY "${_output_binary_dir}/${_DESTINATION}"
QT_SKIP_TRANSLATION "${skip_translation}"
+ CXX_VISIBILITY_PRESET hidden
+ VISIBILITY_INLINES_HIDDEN ON
${_arg_PROPERTIES}
)
append_extra_translations("${name}" "${_arg_EXTRA_TRANSLATIONS}")
diff --git a/src/shared/qtcreator_gui_pch.h b/src/shared/qtcreator_gui_pch.h
index b25dbf67b7..9ac491898b 100644
--- a/src/shared/qtcreator_gui_pch.h
+++ b/src/shared/qtcreator_gui_pch.h
@@ -32,16 +32,7 @@
#if defined __cplusplus
-#include <QEvent>
-#include <QTimer>
-#include <QApplication>
-#include <QBitmap>
-#include <QCursor>
-#include <QImage>
-#include <QLayout>
-#include <QPainter>
-#include <QPixmap>
-#include <QStyle>
-#include <QWidget>
+#include <QtGui>
+#include <QtWidgets>
#endif
diff --git a/src/shared/qtcreator_pch.h b/src/shared/qtcreator_pch.h
index 4988f3d939..8ff33bef08 100644
--- a/src/shared/qtcreator_pch.h
+++ b/src/shared/qtcreator_pch.h
@@ -37,18 +37,7 @@
# undef _POSIX_
#endif
-#include <QCoreApplication>
-#include <QList>
-#include <QVariant>
-#include <QObject>
-#include <QRegExp>
-#include <QString>
-#include <QStringList>
-#include <QTextCodec>
-#include <QPointer>
-#include <QScopedPointer>
-#include <QSharedPointer>
-#include <QDebug>
+#include <QtCore>
#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
#include <QTextStream>