Debugger: imitate windows gdb all uppercase PATH env variable name

Task-number: QTCREATORBUG-19547
Change-Id: I57295b7febd7e017408d5d75ebec7020a7cbb32f
Reviewed-by: hjk <hjk@qt.io>

1 files changed, 11 insertions, 3 deletions

diff --git a/src/plugins/debugger/gdb/gdbengine.cpp b/src/plugins/debugger/gdb/gdbengine.cpp
index d87c33a741..5ec1e38feb 100644
--- a/src/plugins/debugger/gdb/gdbengine.cpp
+++ b/src/plugins/debugger/gdb/gdbengine.cpp
@@ -3955,14 +3955,22 @@ void GdbEngine::loadInitScript()
 
 void GdbEngine::setEnvironmentVariables()
 {
+    auto isWindowsPath = [this](const QString &str){
+        return HostOsInfo::isWindowsHost()
+                && !isRemoteEngine()
+                && str.compare("path", Qt::CaseInsensitive) == 0;
+    };
+
     Environment sysEnv = Environment::systemEnvironment();
     Environment runEnv = runParameters().inferior.environment;
     foreach (const EnvironmentItem &item, sysEnv.diff(runEnv)) {
+        // imitate the weird windows gdb behavior of setting the case of the path environment
+        // variable name to an all uppercase PATH
+        const QString name = isWindowsPath(item.name) ? "PATH" : item.name;
         if (item.operation == EnvironmentItem::Unset)
-            runCommand({"unset environment " + item.name});
+            runCommand({"unset environment " + name});
         else
-            runCommand({"-gdb-set environment " + item.name + '='
-                        + item.value});
+            runCommand({"-gdb-set environment " + name + '=' + item.value});
     }
 }