diff options
| author | Thomas Hartmann <thomas.hartmann@qt.io> | 2017-10-20 10:11:14 +0200 |
|---|---|---|
| committer | Thomas Hartmann <thomas.hartmann@qt.io> | 2017-10-20 13:32:48 +0000 |
| commit | d65f26557efd376e4eeab8d12ff45e2b28fe7610 (patch) | |
| tree | 22ce11e8ed42f92f3389e084d803c3ff8eeba4e5 | |
| parent | 781f15cfaf0abbcaea89f6d39c75d182a5e1c0c4 (diff) | |
| download | qt-creator-d65f26557efd376e4eeab8d12ff45e2b28fe7610.tar.gz | |
QmlDesigner: Fix crash
If the keyboard is used (delete) the list can be empty.
Change-Id: I7f67388d1af84091c8bc8b9a54345bb02dbf6ee2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
| -rw-r--r-- | src/plugins/qmldesigner/qmldesignerextension/connectioneditor/connectionviewwidget.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/plugins/qmldesigner/qmldesignerextension/connectioneditor/connectionviewwidget.cpp b/src/plugins/qmldesigner/qmldesignerextension/connectioneditor/connectionviewwidget.cpp index 2ad6d34d3d..54b771bf0d 100644 --- a/src/plugins/qmldesigner/qmldesignerextension/connectioneditor/connectionviewwidget.cpp +++ b/src/plugins/qmldesigner/qmldesignerextension/connectioneditor/connectionviewwidget.cpp @@ -231,18 +231,24 @@ void ConnectionViewWidget::handleTabChanged(int) void ConnectionViewWidget::removeButtonClicked() { if (currentTab() == ConnectionTab) { + if (ui->connectionView->selectionModel()->selectedRows().isEmpty()) + return; int currentRow = ui->connectionView->selectionModel()->selectedRows().first().row(); ConnectionModel *connectionModel = qobject_cast<ConnectionModel*>(ui->connectionView->model()); if (connectionModel) { connectionModel->deleteConnectionByRow(currentRow); } } else if (currentTab() == BindingTab) { + if (ui->bindingView->selectionModel()->selectedRows().isEmpty()) + return; int currentRow = ui->bindingView->selectionModel()->selectedRows().first().row(); BindingModel *bindingModel = qobject_cast<BindingModel*>(ui->bindingView->model()); if (bindingModel) { bindingModel->deleteBindindByRow(currentRow); } } else if (currentTab() == DynamicPropertiesTab) { + if (ui->dynamicPropertiesView->selectionModel()->selectedRows().isEmpty()) + return; int currentRow = ui->dynamicPropertiesView->selectionModel()->selectedRows().first().row(); DynamicPropertiesModel *dynamicPropertiesModel = qobject_cast<DynamicPropertiesModel*>(ui->dynamicPropertiesView->model()); if (dynamicPropertiesModel) |