summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFawzi Mohamed <fawzi.mohamed@theqtcompany.com>2014-12-04 13:20:18 +0100
committerFawzi Mohamed <fawzi.mohamed@theqtcompany.com>2015-01-22 11:37:26 +0100
commit73a9bea51df2c797f877cc1752578042bd40ff45 (patch)
tree432aae8b18dd7060b34682990fd312cb4deede23
parente1da2d8d9850f278cbe799fa97b3fc62482e64f6 (diff)
downloadqt-creator-73a9bea51df2c797f877cc1752578042bd40ff45.tar.gz
qmljs: do not rely on future.isCanceled to be sticky
Change-Id: I92f32b9cbea1ddb1660895264f853068c31af4cd Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com> Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
-rw-r--r--src/libs/qmljs/qmljsmodelmanagerinterface.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/libs/qmljs/qmljsmodelmanagerinterface.cpp b/src/libs/qmljs/qmljsmodelmanagerinterface.cpp
index 34224193dd..6dfad591d7 100644
--- a/src/libs/qmljs/qmljsmodelmanagerinterface.cpp
+++ b/src/libs/qmljs/qmljsmodelmanagerinterface.cpp
@@ -1007,7 +1007,8 @@ void ModelManagerInterface::importScan(QFutureInterface<void> &future,
future.setProgressRange(0, progressRange); // update max length while iterating?
const bool libOnly = true; // FIXME remove when tested more
const Snapshot snapshot = modelManager->snapshot();
- while (!pathsToScan.isEmpty() && !future.isCanceled()) {
+ bool isCanceled = future.isCanceled();
+ while (!pathsToScan.isEmpty() && !isCanceled) {
ScanItem toScan = pathsToScan.last();
pathsToScan.pop_back();
int pathBudget = (1 << (maxScanDepth + 2 - toScan.depth));
@@ -1044,9 +1045,10 @@ void ModelManagerInterface::importScan(QFutureInterface<void> &future,
workDone += pathBudget * 3 / 4;
}
future.setProgressValue(progressRange * workDone / totalWork);
+ isCanceled = future.isCanceled();
}
future.setProgressValue(progressRange);
- if (future.isCanceled()) {
+ if (isCanceled) {
// assume no work has been done
QMutexLocker l(&modelManager->m_mutex);
for (int i = 0; i < paths.size(); ++i)