diff options
author | hjk <hjk121@nokiamail.com> | 2014-05-30 10:11:10 +0200 |
---|---|---|
committer | hjk <hjk121@nokiamail.com> | 2014-05-30 13:34:25 +0200 |
commit | a9e1eef089cfddf71767b7e9798fbb0fd0b31168 (patch) | |
tree | d17dfc002b5a5bddda965b956cf3a6fe1f1566e6 | |
parent | c3285d0ed0416482a0d5224d3d4246dc9e2ebe41 (diff) | |
download | qt-creator-a9e1eef089cfddf71767b7e9798fbb0fd0b31168.tar.gz |
Debugger: Limit QObject name dumper to a more-than reasonable maximum
GDB can crash on to big chunks. Since this here is a convenience
feature only, hard-limiting it to length 200 seems ok as work-around.
Task-number: QTCREATORBUG-12330
Change-Id: Ia6ebf16f3528d91020d19851641f42c1e421fe15
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
-rw-r--r-- | share/qtcreator/debugger/dumper.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/share/qtcreator/debugger/dumper.py b/share/qtcreator/debugger/dumper.py index 1b07c10759..dc8b50628b 100644 --- a/share/qtcreator/debugger/dumper.py +++ b/share/qtcreator/debugger/dumper.py @@ -937,7 +937,9 @@ class DumperBase: data, size, alloc = self.byteArrayDataHelper(objectName) - if size == 0: + # Object names are short, and GDB can crash on to big chunks. + # Since this here is a convenience feature only, limit it. + if size <= 0 or size > 80: return False raw = self.readMemory(data, 2 * size) |