clang-tidy: Fix 'cppcoreguidelines-pro-type-member-init' warnings

Also, fix undefined behavior when setting and reading different field of
a union (Lexer, Token) - according to the C++ Standard, it is not
allowed to use a union to zero members of a struct.

Treat these warnings as errors now.

Change-Id: I0f6d071217ef55e2c75c51138fcff47048eca62f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

2 files changed, 6 insertions, 12 deletions

diff --git a/src/lib/corelib/buildgraph/artifact.cpp b/src/lib/corelib/buildgraph/artifact.cpp
index e82919560..8d3a8bd3f 100644
--- a/src/lib/corelib/buildgraph/artifact.cpp
+++ b/src/lib/corelib/buildgraph/artifact.cpp
@@ -51,9 +51,13 @@
 namespace qbs {
 namespace Internal {
 
-Artifact::Artifact()
+Artifact::Artifact() :
+    artifactType(ArtifactType::Unknown),
+    inputsScanned(false),
+    timestampRetrieved(false),
+    alwaysUpdated(false),
+    oldDataPossiblyPresent(true)
 {
-    initialize();
 }
 
 Artifact::~Artifact()
@@ -120,15 +124,6 @@ RuleNode *Artifact::producer() const
     return *ruleNodes.begin();
 }
 
-void Artifact::initialize()
-{
-    artifactType = Unknown;
-    inputsScanned = false;
-    timestampRetrieved = false;
-    alwaysUpdated = true;
-    oldDataPossiblyPresent = true;
-}
-
 const TypeFilter<Artifact> Artifact::parentArtifacts() const
 {
     return TypeFilter<Artifact>(parents);
diff --git a/src/lib/corelib/buildgraph/artifact.h b/src/lib/corelib/buildgraph/artifact.h
index ee3acea59..2572a3b52 100644
--- a/src/lib/corelib/buildgraph/artifact.h
+++ b/src/lib/corelib/buildgraph/artifact.h
@@ -114,7 +114,6 @@ public:
     bool alwaysUpdated : 1;
     bool oldDataPossiblyPresent : 1;
 
-    void initialize();
     const TypeFilter<Artifact> parentArtifacts() const;
     const TypeFilter<Artifact> childArtifacts() const;
     void onChildDisconnected(BuildGraphNode *child) override;