diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2023-04-24 16:03:43 +0200 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2023-04-26 12:29:46 +0000 |
| commit | 70189916933cffaa3c2ed767d82f6a7d524a164e (patch) | |
| tree | ccc5541aef730eb4119d73343ffe7f6eb38c4fb6 | |
| parent | 9cfd88b1b7cca084fabe8053d988aa0685f0cfb3 (diff) | |
| download | qbs-70189916933cffaa3c2ed767d82f6a7d524a164e.tar.gz | |
ProjectTreeBuilder: Fix clang-tidy complaints
Amends fb52fed84a1510a7de0172e643d6fd66a780e2e8.
Change-Id: I5eb92e515dae3059b9ba3b118a683e0aedb97ddb
Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
| -rw-r--r-- | src/lib/corelib/language/projecttreebuilder.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/lib/corelib/language/projecttreebuilder.cpp b/src/lib/corelib/language/projecttreebuilder.cpp index 3786517ad..bc1e4ab9a 100644 --- a/src/lib/corelib/language/projecttreebuilder.cpp +++ b/src/lib/corelib/language/projecttreebuilder.cpp @@ -129,9 +129,9 @@ public: versionRange(dependency.versionRange), parameters(dependency.parameters), fallbackMode(FallbackMode::Disabled), checkProduct(false) {} ResolvedAndMultiplexedDependsItem(const ResolvedDependsItem &dependency, - const QualifiedId &name, - const QString &profile, const QString &multiplexId) - : item(dependency.item), name(name), profile(profile), multiplexId(multiplexId), + QualifiedId name, QString profile, QString multiplexId) + : item(dependency.item), name(std::move(name)), profile(std::move(profile)), + multiplexId(std::move(multiplexId)), versionRange(dependency.versionRange), parameters(dependency.parameters), limitToSubProject(dependency.limitToSubProject), fallbackMode(dependency.fallbackMode), requiredLocally(dependency.requiredLocally), @@ -1926,7 +1926,7 @@ ProjectTreeBuilder::Private::loadModule(ProductContext &product, Item *loadingIt QString loadingName; if (loadingItem == product.item) { loadingName = product.name; - } else if (product.resolveDependenciesState.size() > 0) { + } else if (!product.resolveDependenciesState.empty()) { const auto &loadingItemOrigin = product.resolveDependenciesState.front().loadingItemOrigin; loadingName = loadingItemOrigin.name.toString() + loadingItemOrigin.multiplexId + loadingItemOrigin.profile; |