diff options
author | Ivan Komissarov <abbapoh@gmail.com> | 2023-05-01 01:56:52 +0300 |
---|---|---|
committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2023-05-02 12:52:07 +0000 |
commit | 1f5f46e572cf7ffcd2ae4e90024349928719ba35 (patch) | |
tree | 49181560c1ce968822a9e15c0dc30fba00f52232 | |
parent | 91ecfffe417eb58df145cb03e7d741b111f0dcf2 (diff) | |
download | qbs-1f5f46e572cf7ffcd2ae4e90024349928719ba35.tar.gz |
Use RAII in JSSourceValueCreator in tst_language.cpp
Change-Id: Ibd4dd3bf5e482442079f564fa3b4e8f5adcb74f1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
-rw-r--r-- | tests/auto/language/tst_language.cpp | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/tests/auto/language/tst_language.cpp b/tests/auto/language/tst_language.cpp index 680aae834..0ac71c8a0 100644 --- a/tests/auto/language/tst_language.cpp +++ b/tests/auto/language/tst_language.cpp @@ -1566,25 +1566,20 @@ void TestLanguage::invalidOverrides_data() class JSSourceValueCreator { FileContextPtr m_fileContext; - QList<QString *> m_strings; + std::vector<std::unique_ptr<QString>> m_strings; public: JSSourceValueCreator(const FileContextPtr &fileContext) : m_fileContext(fileContext) { } - ~JSSourceValueCreator() - { - qDeleteAll(m_strings); - } - JSSourceValuePtr create(const QString &sourceCode) { JSSourceValuePtr value = JSSourceValue::create(); value->setFile(m_fileContext); - const auto str = new QString(sourceCode); - m_strings.push_back(str); - value->setSourceCode(*str); + auto str = std::make_unique<QString>(sourceCode); + value->setSourceCode(*str.get()); + m_strings.push_back(std::move(str)); return value; } }; |