diff options
| author | Ivan Komissarov <abbapoh@gmail.com> | 2022-03-29 09:37:31 +0300 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2022-05-20 15:35:22 +0000 |
| commit | 864f7ed09316e4f629423f1c4f2d05af244e2339 (patch) | |
| tree | dac34797b23bf80c5630481e3d672f201e57d713 | |
| parent | 6e66e2dd102aba238d7b374ee30ffc34cf9dde05 (diff) | |
| download | qbs-1.22.tar.gz | |
Fix clang-tidy job1.22
Change-Id: Ifdaed0906a4619a8f681fd900f0939cf26b0f059
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
| -rw-r--r-- | src/app/qbs-setup-toolchains/dmcprobe.cpp | 8 | ||||
| -rw-r--r-- | src/app/qbs-setup-toolchains/dmcprobe.h | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/app/qbs-setup-toolchains/dmcprobe.cpp b/src/app/qbs-setup-toolchains/dmcprobe.cpp index d542f9bcd..cbe113dfd 100644 --- a/src/app/qbs-setup-toolchains/dmcprobe.cpp +++ b/src/app/qbs-setup-toolchains/dmcprobe.cpp @@ -101,7 +101,7 @@ static QStringList dumpOutput(const QFileInfo &compiler, const QStringList &flag args.push_back(QDir::toNativeSeparators(filePath)); QProcess p; - p.start(compiler.absoluteFilePath(), std::move(args)); + p.start(compiler.absoluteFilePath(), args); p.waitForFinished(3000); fakeIn.remove(); static QRegularExpression re(QLatin1String("\\r?\\n")); @@ -144,7 +144,7 @@ static std::optional<Target> dumpDmcTarget(const QFileInfo &compiler, const QStr static std::vector<Profile> createDmcProfileHelper(const ToolchainInstallInfo &info, Settings *settings, - QString profileName = QString()) + QStringView profileName = {}) { const QFileInfo compiler = info.compilerPath; std::vector<Profile> profiles; @@ -241,10 +241,10 @@ bool isDmcCompiler(const QString &compilerName) } void createDmcProfile(const QFileInfo &compiler, Settings *settings, - QString profileName) + QStringView profileName) { const ToolchainInstallInfo info = {compiler, Version{}}; - createDmcProfileHelper(info, settings, std::move(profileName)); + createDmcProfileHelper(info, settings, profileName); } void dmcProbe(Settings *settings, std::vector<Profile> &profiles) diff --git a/src/app/qbs-setup-toolchains/dmcprobe.h b/src/app/qbs-setup-toolchains/dmcprobe.h index a2fbc74cb..3159c2df5 100644 --- a/src/app/qbs-setup-toolchains/dmcprobe.h +++ b/src/app/qbs-setup-toolchains/dmcprobe.h @@ -54,7 +54,7 @@ class Settings; bool isDmcCompiler(const QString &compilerName); void createDmcProfile(const QFileInfo &compiler, qbs::Settings *settings, - QString profileName); + QStringView profileName); void dmcProbe(qbs::Settings *settings, std::vector<qbs::Profile> &profiles); |