summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@gmail.com>2015-01-09 15:38:48 +0100
committerVictor Stinner <victor.stinner@gmail.com>2015-01-09 15:38:48 +0100
commit15b5d58f450cd31e129d251e60356992eaa70955 (patch)
tree2f3cbfa30ebd33ea206f6893a9e264e21e8fb560
parentb0110fd586daf7ae1766d929802c21a70de0b12a (diff)
downloadtrollius-15b5d58f450cd31e129d251e60356992eaa70955.tar.gz
Remove outdated TODO/XXX
* Yes, futures errors (Error, CancelledError, TimeoutError, ...) are aliases of concurrent.futures errors * InvalidStateError: the state is already logged in the message when the exception is raised * call_exception_handler() now makes possible to decide how to handle exceptions * Add a docstring to _UnixDefaultEventLoopPolicy
-rw-r--r--asyncio/futures.py2
-rw-r--r--asyncio/proactor_events.py3
-rw-r--r--asyncio/selector_events.py1
-rw-r--r--asyncio/unix_events.py5
4 files changed, 3 insertions, 8 deletions
diff --git a/asyncio/futures.py b/asyncio/futures.py
index f46d008..e0e12f0 100644
--- a/asyncio/futures.py
+++ b/asyncio/futures.py
@@ -20,7 +20,6 @@ _FINISHED = 'FINISHED'
_PY34 = sys.version_info >= (3, 4)
-# TODO: Do we really want to depend on concurrent.futures internals?
Error = concurrent.futures._base.Error
CancelledError = concurrent.futures.CancelledError
TimeoutError = concurrent.futures.TimeoutError
@@ -30,7 +29,6 @@ STACK_DEBUG = logging.DEBUG - 1 # heavy-duty debugging
class InvalidStateError(Error):
"""The operation is not allowed in this state."""
- # TODO: Show the future, its state, the method, and the required state.
class _TracebackLogger:
diff --git a/asyncio/proactor_events.py b/asyncio/proactor_events.py
index 44a8197..0a4d068 100644
--- a/asyncio/proactor_events.py
+++ b/asyncio/proactor_events.py
@@ -487,7 +487,8 @@ class BaseProactorEventLoop(base_events.BaseEventLoop):
self.call_soon(loop)
def _process_events(self, event_list):
- pass # XXX hard work currently done in poll
+ # Events are processed in the IocpProactor._poll() method
+ pass
def _stop_accept_futures(self):
for future in self._accept_futures.values():
diff --git a/asyncio/selector_events.py b/asyncio/selector_events.py
index 58b61f1..307a9ad 100644
--- a/asyncio/selector_events.py
+++ b/asyncio/selector_events.py
@@ -145,7 +145,6 @@ class BaseSelectorEventLoop(base_events.BaseEventLoop):
pass # False alarm.
except OSError as exc:
# There's nowhere to send the error, so just log it.
- # TODO: Someone will want an error handler for this.
if exc.errno in (errno.EMFILE, errno.ENFILE,
errno.ENOBUFS, errno.ENOMEM):
# Some platforms (e.g. Linux keep reporting the FD as
diff --git a/asyncio/unix_events.py b/asyncio/unix_events.py
index 91e43cf..1a4d418 100644
--- a/asyncio/unix_events.py
+++ b/asyncio/unix_events.py
@@ -496,9 +496,6 @@ class _UnixWritePipeTransport(transports._FlowControlMixin,
def can_write_eof(self):
return True
- # TODO: Make the relationships between write_eof(), close(),
- # abort(), _fatal_error() and _close() more straightforward.
-
def write_eof(self):
if self._closing:
return
@@ -897,7 +894,7 @@ class FastChildWatcher(BaseChildWatcher):
class _UnixDefaultEventLoopPolicy(events.BaseDefaultEventLoopPolicy):
- """XXX"""
+ """UNIX event loop policy with a watcher for child processes."""
_loop_factory = _UnixSelectorEventLoop
def __init__(self):