diff options
author | Miroslav Šedivý <6774676+eumiro@users.noreply.github.com> | 2021-04-11 23:30:45 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-11 22:30:45 +0100 |
commit | 963f7c548e044d48e68002bd5d99cdf495c5ac7e (patch) | |
tree | dee7893f5d7eaa0ff7cdcd2980dca01cb3c02bf0 /src/tox/session | |
parent | 931159940c55f960b68c3dc1324150c2093e84d6 (diff) | |
download | tox-git-963f7c548e044d48e68002bd5d99cdf495c5ac7e.tar.gz |
Minor code improvements (#2017)
* Use !r to repr strings
* Simplify loops and expressions
* Improve exception traceback
* Add Python 3.10 to installation.rst
Diffstat (limited to 'src/tox/session')
-rw-r--r-- | src/tox/session/cmd/run/common.py | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/tox/session/cmd/run/common.py b/src/tox/session/cmd/run/common.py index 49704e4e..a65f944f 100644 --- a/src/tox/session/cmd/run/common.py +++ b/src/tox/session/cmd/run/common.py @@ -33,7 +33,7 @@ class SkipMissingInterpreterAction(Action): ) -> None: value = "true" if values is None else values if value not in ("config", "true", "false"): - raise ArgumentError(self, f"value must be 'config', 'true', or 'false' (got {repr(value)})") + raise ArgumentError(self, f"value must be 'config', 'true', or 'false' (got {value!r})") setattr(namespace, self.dest, value) @@ -144,7 +144,7 @@ def report(start: float, runs: List[ToxEnvRunResult], is_colored: bool) -> int: for run in runs: all_good &= run.code == Outcome.OK or run.ignore_outcome duration_individual = [o.elapsed for o in run.outcomes] - extra = f"+cmd[{','.join(f'{i:.2f}' for i in duration_individual)}]" if len(duration_individual) else "" + extra = f"+cmd[{','.join(f'{i:.2f}' for i in duration_individual)}]" if duration_individual else "" setup = run.duration - sum(duration_individual) msg, color = _get_outcome_message(run) out = f" {run.name}: {msg} ({run.duration:.2f}{f'=setup[{setup:.2f}]{extra}' if extra else ''} seconds)" @@ -227,10 +227,7 @@ class ToxSpinner(Spinner): def update_spinner(self, result: ToxEnvRunResult, success: bool) -> None: if success: - if result.skipped: - done = self.skip - else: - done = self.succeed + done = self.skip if result.skipped else self.succeed else: done = self.fail done(result.name) |