1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
|
from sqlalchemy import Integer
from sqlalchemy import select
from sqlalchemy import sql
from sqlalchemy import true
from sqlalchemy.testing import config
from sqlalchemy.testing import engines
from sqlalchemy.testing import expect_warnings
from sqlalchemy.testing import fixtures
from sqlalchemy.testing import is_
from sqlalchemy.testing.schema import Column
from sqlalchemy.testing.schema import Table
def find_unmatching_froms(query, start=None):
compiled = query.compile(linting=sql.COLLECT_CARTESIAN_PRODUCTS)
return compiled.from_linter.lint(start)
class TestFindUnmatchingFroms(fixtures.TablesTest):
@classmethod
def define_tables(cls, metadata):
Table("table_a", metadata, Column("col_a", Integer, primary_key=True))
Table("table_b", metadata, Column("col_b", Integer, primary_key=True))
Table("table_c", metadata, Column("col_c", Integer, primary_key=True))
Table("table_d", metadata, Column("col_d", Integer, primary_key=True))
def setup(self):
self.a = self.tables.table_a
self.b = self.tables.table_b
self.c = self.tables.table_c
self.d = self.tables.table_d
def test_everything_is_connected(self):
query = (
select([self.a])
.select_from(self.a.join(self.b, self.a.c.col_a == self.b.c.col_b))
.select_from(self.c)
.select_from(self.d)
.where(self.d.c.col_d == self.b.c.col_b)
.where(self.c.c.col_c == self.d.c.col_d)
.where(self.c.c.col_c == 5)
)
froms, start = find_unmatching_froms(query)
assert not froms
for start in self.a, self.b, self.c, self.d:
froms, start = find_unmatching_froms(query, start)
assert not froms
def test_plain_cartesian(self):
query = select([self.a]).where(self.b.c.col_b == 5)
froms, start = find_unmatching_froms(query, self.a)
assert start == self.a
assert froms == {self.b}
froms, start = find_unmatching_froms(query, self.b)
assert start == self.b
assert froms == {self.a}
def test_count_non_eq_comparison_operators(self):
query = select([self.a]).where(self.a.c.col_a > self.b.c.col_b)
froms, start = find_unmatching_froms(query, self.a)
is_(start, None)
is_(froms, None)
def test_dont_count_non_comparison_operators(self):
query = select([self.a]).where(self.a.c.col_a + self.b.c.col_b == 5)
froms, start = find_unmatching_froms(query, self.a)
assert start == self.a
assert froms == {self.b}
def test_disconnect_between_ab_cd(self):
query = (
select([self.a])
.select_from(self.a.join(self.b, self.a.c.col_a == self.b.c.col_b))
.select_from(self.c)
.select_from(self.d)
.where(self.c.c.col_c == self.d.c.col_d)
.where(self.c.c.col_c == 5)
)
for start in self.a, self.b:
froms, start = find_unmatching_froms(query, start)
assert start == start
assert froms == {self.c, self.d}
for start in self.c, self.d:
froms, start = find_unmatching_froms(query, start)
assert start == start
assert froms == {self.a, self.b}
def test_c_and_d_both_disconnected(self):
query = (
select([self.a])
.select_from(self.a.join(self.b, self.a.c.col_a == self.b.c.col_b))
.where(self.c.c.col_c == 5)
.where(self.d.c.col_d == 10)
)
for start in self.a, self.b:
froms, start = find_unmatching_froms(query, start)
assert start == start
assert froms == {self.c, self.d}
froms, start = find_unmatching_froms(query, self.c)
assert start == self.c
assert froms == {self.a, self.b, self.d}
froms, start = find_unmatching_froms(query, self.d)
assert start == self.d
assert froms == {self.a, self.b, self.c}
def test_now_connected(self):
query = (
select([self.a])
.select_from(self.a.join(self.b, self.a.c.col_a == self.b.c.col_b))
.select_from(self.c.join(self.d, self.c.c.col_c == self.d.c.col_d))
.where(self.c.c.col_c == self.b.c.col_b)
.where(self.c.c.col_c == 5)
.where(self.d.c.col_d == 10)
)
froms, start = find_unmatching_froms(query)
assert not froms
for start in self.a, self.b, self.c, self.d:
froms, start = find_unmatching_froms(query, start)
assert not froms
def test_disconnected_subquery(self):
subq = (
select([self.a]).where(self.a.c.col_a == self.b.c.col_b).subquery()
)
stmt = select([self.c]).select_from(subq)
froms, start = find_unmatching_froms(stmt, self.c)
assert start == self.c
assert froms == {subq}
froms, start = find_unmatching_froms(stmt, subq)
assert start == subq
assert froms == {self.c}
def test_now_connect_it(self):
subq = (
select([self.a]).where(self.a.c.col_a == self.b.c.col_b).subquery()
)
stmt = (
select([self.c])
.select_from(subq)
.where(self.c.c.col_c == subq.c.col_a)
)
froms, start = find_unmatching_froms(stmt)
assert not froms
for start in self.c, subq:
froms, start = find_unmatching_froms(stmt, start)
assert not froms
def test_right_nested_join_without_issue(self):
query = select([self.a]).select_from(
self.a.join(
self.b.join(self.c, self.b.c.col_b == self.c.c.col_c),
self.a.c.col_a == self.b.c.col_b,
)
)
froms, start = find_unmatching_froms(query)
assert not froms
for start in self.a, self.b, self.c:
froms, start = find_unmatching_froms(query, start)
assert not froms
def test_join_on_true(self):
# test that a join(a, b) counts a->b as an edge even if there isn't
# actually a join condition. this essentially allows a cartesian
# product to be added explicitly.
query = select([self.a]).select_from(self.a.join(self.b, true()))
froms, start = find_unmatching_froms(query)
assert not froms
def test_right_nested_join_with_an_issue(self):
query = (
select([self.a])
.select_from(
self.a.join(
self.b.join(self.c, self.b.c.col_b == self.c.c.col_c),
self.a.c.col_a == self.b.c.col_b,
)
)
.where(self.d.c.col_d == 5)
)
for start in self.a, self.b, self.c:
froms, start = find_unmatching_froms(query, start)
assert start == start
assert froms == {self.d}
froms, start = find_unmatching_froms(query, self.d)
assert start == self.d
assert froms == {self.a, self.b, self.c}
def test_no_froms(self):
query = select([1])
froms, start = find_unmatching_froms(query)
assert not froms
class TestLinter(fixtures.TablesTest):
@classmethod
def define_tables(cls, metadata):
Table("table_a", metadata, Column("col_a", Integer, primary_key=True))
Table("table_b", metadata, Column("col_b", Integer, primary_key=True))
@classmethod
def setup_bind(cls):
# from linting is enabled by default
return config.db
def test_noop_for_unhandled_objects(self):
with self.bind.connect() as conn:
conn.exec_driver_sql("SELECT 1;").fetchone()
def test_does_not_modify_query(self):
with self.bind.connect() as conn:
[result] = conn.execute(select([1])).fetchone()
assert result == 1
def test_warn_simple(self):
a, b = self.tables("table_a", "table_b")
query = select([a.c.col_a]).where(b.c.col_b == 5)
with expect_warnings(
r"SELECT statement has a cartesian product between FROM "
r'element\(s\) "table_[ab]" '
r'and FROM element "table_[ba]"'
):
with self.bind.connect() as conn:
conn.execute(query)
def test_warn_anon_alias(self):
a, b = self.tables("table_a", "table_b")
b_alias = b.alias()
query = select([a.c.col_a]).where(b_alias.c.col_b == 5)
with expect_warnings(
r"SELECT statement has a cartesian product between FROM "
r'element\(s\) "table_(?:a|b_1)" '
r'and FROM element "table_(?:a|b_1)"'
):
with self.bind.connect() as conn:
conn.execute(query)
def test_warn_anon_cte(self):
a, b = self.tables("table_a", "table_b")
b_cte = select([b]).cte()
query = select([a.c.col_a]).where(b_cte.c.col_b == 5)
with expect_warnings(
r"SELECT statement has a cartesian product between "
r"FROM element\(s\) "
r'"(?:anon_1|table_a)" '
r'and FROM element "(?:anon_1|table_a)"'
):
with self.bind.connect() as conn:
conn.execute(query)
def test_no_linting(self):
eng = engines.testing_engine(options={"enable_from_linting": False})
eng.pool = self.bind.pool # needed for SQLite
a, b = self.tables("table_a", "table_b")
query = select([a.c.col_a]).where(b.c.col_b == 5)
with eng.connect() as conn:
conn.execute(query)
|
