summaryrefslogtreecommitdiff
path: root/test/sql
diff options
context:
space:
mode:
authorFederico Caselli <cfederico87@gmail.com>2021-04-05 21:57:24 +0200
committerMike Bayer <mike_mp@zzzcomputing.com>2021-04-06 17:18:44 -0400
commit3de954bc027ebf655e7ed26c83cfb3fd4b7b5edf (patch)
tree207b479aee69c640acb4143567fe882084ec1d0c /test/sql
parent165c3a65dcb1ba3f42ecf2b5da7c298bdc259f9b (diff)
downloadsqlalchemy-3de954bc027ebf655e7ed26c83cfb3fd4b7b5edf.tar.gz
Table arguments name and metadata are positional only
The :class:`_sql.Table` object now raises an informative error message if it is instantiated without passing at least the :paramref:`_sql.Table.name` and :paramref:`_sql.Table.metadata` arguments positionally. Previously, if these were passed as keyword arguments, the object would silently fail to initialize correctly. Fixes: #6135 Change-Id: I54d0c89fd549fc504289a87ea0bb37369f982b06
Diffstat (limited to 'test/sql')
-rw-r--r--test/sql/test_metadata.py15
1 files changed, 15 insertions, 0 deletions
diff --git a/test/sql/test_metadata.py b/test/sql/test_metadata.py
index e2f015b00..25834ac76 100644
--- a/test/sql/test_metadata.py
+++ b/test/sql/test_metadata.py
@@ -47,6 +47,7 @@ from sqlalchemy.testing import AssertsCompiledSQL
from sqlalchemy.testing import ComparesTables
from sqlalchemy.testing import emits_warning
from sqlalchemy.testing import eq_
+from sqlalchemy.testing import expect_raises_message
from sqlalchemy.testing import fixtures
from sqlalchemy.testing import is_
from sqlalchemy.testing import is_false
@@ -2022,6 +2023,20 @@ class PKAutoIncrementTest(fixtures.TestBase):
t3.append_constraint(pk)
is_(pk._autoincrement_column, t3.c.a)
+ def test_no_kw_args(self):
+ with expect_raises_message(
+ TypeError,
+ r"Table\(\) takes at least two positional-only arguments",
+ check_context=False,
+ ):
+ Table(name="foo", metadata=MetaData())
+ with expect_raises_message(
+ TypeError,
+ r"Table\(\) takes at least two positional-only arguments",
+ check_context=False,
+ ):
+ Table("foo", metadata=MetaData())
+
class SchemaTypeTest(fixtures.TestBase):
__backend__ = True