summaryrefslogtreecommitdiff
path: root/test/sql/test_resultset.py
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2020-02-24 13:54:37 -0500
committerMike Bayer <mike_mp@zzzcomputing.com>2020-02-24 13:54:37 -0500
commit5d42051c2e575713ffb8ea4f43ef1c2145b83c97 (patch)
treec6a863de5a20bd6e67cd160c229f0aa06347f66e /test/sql/test_resultset.py
parent955f4a27c37ba73901745b89eb555eb8681d4b9f (diff)
downloadsqlalchemy-5d42051c2e575713ffb8ea4f43ef1c2145b83c97.tar.gz
Deprecate row.keys() for 2.0, not 1.x
row.keys() is used by any use case that applies dict() to a row. Access of elements by string key is also a 2.0 deprecation not 1.4 so for rudimental dict(row) support make sure that is all a 2.0 thing. Fixes current Alembic test suite. Change-Id: I895496324133d615676cd76bc5f2c5f4a83e9131
Diffstat (limited to 'test/sql/test_resultset.py')
-rw-r--r--test/sql/test_resultset.py10
1 files changed, 10 insertions, 0 deletions
diff --git a/test/sql/test_resultset.py b/test/sql/test_resultset.py
index 2a6851a99..87886c4fa 100644
--- a/test/sql/test_resultset.py
+++ b/test/sql/test_resultset.py
@@ -1030,6 +1030,16 @@ class ResultProxyTest(fixtures.TablesTest):
eq_(list(row._mapping.keys()), ["user_id", "user_name"])
eq_(row._fields, ("user_id", "user_name"))
+ def test_row_keys_legacy_dont_warn(self):
+ users = self.tables.users
+
+ users.insert().execute(user_id=1, user_name="foo")
+ result = users.select().execute()
+ row = result.first()
+ # DO NOT WARN DEPRECATED IN 1.x, ONLY 2.0 WARNING
+ eq_(dict(row), {"user_id": 1, "user_name": "foo"})
+ eq_(row.keys(), ["user_id", "user_name"])
+
def test_keys_anon_labels(self):
"""test [ticket:3483]"""