Add deprecation warnings to all deprecated APIs

A large change throughout the library has ensured that all objects, parameters,
and behaviors which have been noted as deprecated or legacy now emit
``DeprecationWarning`` warnings when invoked.   As the Python 3 interpreter now
defaults to displaying deprecation warnings, as well as that modern test suites
based on tools like tox and pytest tend to display deprecation warnings,
this change should make it easier to note what API features are obsolete.

See the notes added to the changelog and migration notes for further
details.

Fixes: #4393
Change-Id: If0ea11a1fc24f9a8029352eeadfc49a7a54c0a1b

2 files changed, 10 insertions, 12 deletions

diff --git a/test/dialect/postgresql/test_dialect.py b/test/dialect/postgresql/test_dialect.py
index d4e1cddc4..cadcbdc1c 100644
--- a/test/dialect/postgresql/test_dialect.py
+++ b/test/dialect/postgresql/test_dialect.py
@@ -407,7 +407,7 @@ class MiscBackendTest(
     @testing.fails_on("+zxjdbc", "psycopg2/pg8000 specific assertion")
     @testing.requires.psycopg2_or_pg8000_compatibility
     def test_numeric_raise(self):
-        stmt = text("select cast('hi' as char) as hi", typemap={"hi": Numeric})
+        stmt = text("select cast('hi' as char) as hi").columns(hi=Numeric)
         assert_raises(exc.InvalidRequestError, testing.db.execute, stmt)
 
     @testing.only_if(
diff --git a/test/dialect/postgresql/test_types.py b/test/dialect/postgresql/test_types.py
index f20f92251..e55754f1b 100644
--- a/test/dialect/postgresql/test_types.py
+++ b/test/dialect/postgresql/test_types.py
@@ -165,8 +165,9 @@ class EnumTest(fixtures.TestBase, AssertsExecutionResults):
         'zxjdbc fails on ENUM: column "XXX" is of type '
         "XXX but expression is of type character varying",
     )
+    @testing.provide_metadata
     def test_create_table(self):
-        metadata = MetaData(testing.db)
+        metadata = self.metadata
         t1 = Table(
             "table",
             metadata,
@@ -175,19 +176,16 @@ class EnumTest(fixtures.TestBase, AssertsExecutionResults):
                 "value", Enum("one", "two", "three", name="onetwothreetype")
             ),
         )
-        t1.create()
-        t1.create(checkfirst=True)  # check the create
-        try:
-            t1.insert().execute(value="two")
-            t1.insert().execute(value="three")
-            t1.insert().execute(value="three")
+        with testing.db.connect() as conn:
+            t1.create(conn)
+            t1.create(conn, checkfirst=True)  # check the create
+            conn.execute(t1.insert(), value="two")
+            conn.execute(t1.insert(), value="three")
+            conn.execute(t1.insert(), value="three")
             eq_(
-                t1.select().order_by(t1.c.id).execute().fetchall(),
+                conn.execute(t1.select().order_by(t1.c.id)).fetchall(),
                 [(1, "two"), (2, "three"), (3, "three")],
             )
-        finally:
-            metadata.drop_all()
-            metadata.drop_all()
 
     def test_name_required(self):
         metadata = MetaData(testing.db)